Delete and ignore Cargo.lock #8
Conversation
Bumps [xml-rs](https://github.com/kornelski/xml-rs) from 0.8.4 to 0.8.14. - [Changelog](https://github.com/kornelski/xml-rs/blob/main/Changelog.md) - [Commits](kornelski/xml-rs@0.8.4...0.8.14) --- updated-dependencies: - dependency-name: xml-rs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Good catch! This is my first library and totally an oversight on my side. According to the cargo book, libraries, like this repo, should ignore the Cargo.lock file. As the example project provides an example of a basic application, I think the Cargo.lock file should maybe stay in that case? So the gitignore should only reference the root lock file. What do you think? |
|
Oops, sorry with the assignees. Force of habit 😅 |
True, but if you agree with #9 then I don't think it's worth it to fix this anymore. Because that PR removes the need for Cargo.toml and Cargo.lock in examples altogether |
|
Then I'll take a look at #9 first. |
|
Can you take a look if there's something in here that's still relevant? |
|
All fixed with #10 |
Afaik libraries should not have their Cargo.lock in the repository (see bevy repo for example).
When I cloned and built this repo I got some weird regex parsing errors until I deleted Cargo.lock and rebuilt.