Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to create and run examples #9

Closed
wants to merge 4 commits into from

Conversation

GitGhillie
Copy link
Collaborator

@GitGhillie GitGhillie commented Sep 12, 2023

This took a lot more changes than I had hoped for, but:
Pros:

  • Run examples with cargo run --example hello_world instead of cargo run -p libfmod_bevy_examples_hello_world
  • Easier to add new examples (hoping to work on this soon :)
  • It's more like the Bevy repo
  • If I understand correctly this also makes it possible for the package to be uploaded to crates.io. Though the name is already reserved iirc.

Cons:
Not enough Rust experience for me to be able to say. I'd be interested to hear your thoughts.

Salzian and others added 4 commits March 13, 2023 22:56
Bumps [xml-rs](https://github.com/kornelski/xml-rs) from 0.8.4 to 0.8.14.
- [Changelog](https://github.com/kornelski/xml-rs/blob/main/Changelog.md)
- [Commits](kornelski/xml-rs@0.8.4...0.8.14)

---
updated-dependencies:
- dependency-name: xml-rs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Salzian
Copy link
Owner

Salzian commented Sep 15, 2023

In retrospective, I feel like my workspace approach is overkill for this simple library. I will prepare a PR refactoring to a non-workspace version. That should clear some things up. We can then compare the PRs and choose a solution.

@GitGhillie
Copy link
Collaborator Author

That sounds like the way to go indeed

@GitGhillie GitGhillie closed this Sep 16, 2023
@GitGhillie
Copy link
Collaborator Author

Closed due to restructuring repo

@GitGhillie GitGhillie deleted the examples branch September 22, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants