-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.60.x #6546
Release/v0.60.x #6546
Conversation
* feat: update clickhouse reader to support new trace schema * fix: minor fixes * fix: address comments * fix: add changes to overview function * fix: add changes to overview function * fix: use hardcoded true * fix: address comments
Sync/post release v0.59
* feat: added the host list view and filters (#6210) * feat: added the host list view and filters * feat: removed group by filter and added autocomplete for where clause * feat: updated the table view and added the pagination * feat: pass updated filters to api to get filtered data in the list * feat: added global time range and order by for cpu,memory,iowait,load * feat: added order by and color codes for cpu and memory usage progress bar * refactor: removed inline styles * Host lists improvement (#6366) * style: added new style changes for date time selection in host lists view * style: added padding to date time selector * style: removed unnecessary styles for host tabs * style: removed unused css * feat: added the host detail view (#6267) * Host containers (#6297) * feat: added the host detail view * feat: completed containers and processes details view * Show host metrics panels in metrics tab. (#6306) * feat: added the host detail view * feat: completed containers and processes details view * feat: added host metrics panels in metrics tabs * refactor: removed inline styles from host containers and processes tabs * style: added top and bottom margin to containers and processes tab * Metrics time selection (#6360) * feat: added the host detail view * feat: completed containers and processes details view * feat: added host metrics panels in metrics tabs * refactor: removed inline styles from host containers and processes tabs * feat: added logs and traces tab in host metrics detail view * chore: removed console statements * feat: added DateTimeSelection component in metrics tab * style: added top and bottom margin to containers and processes tab * style: removed inline styles * feat: added logs and traces tab in host metrics detail view (#6359) * feat: added the host detail view * feat: completed containers and processes details view * feat: added host metrics panels in metrics tabs * refactor: removed inline styles from host containers and processes tabs * feat: added logs and traces tab in host metrics detail view * chore: removed console statements * feat: added filters and time selection in traces tab * fix: resolved metrics,logs and traces tab issues * feat: added navigation for logs and traces to respective explorer pages * fix: added the code for logs tab and navigation to respective explorer page * fix: added fixes for date time selection custom issue * style: added styles for light mode * refactor: removed unused code and added comments * refactor: added new code for host metric attribute keys * feat: reset query data once we are on infra monitoring page * chore: remove optional parameter from get attributes and groupby interfaces * feat: update ui as per the designs * fix: logs list, time select and other ui issues * feat: update title for infra monitoring page * feat: update copies * feat: update styles for light mode * fix: reset page size on filter, open explorers in new tab, enable horizontal scroll * feat: traces tab updates * feat: move infra monitoring behind ff * fix: remove sorting from host listing page --------- Co-authored-by: Yunus M <myounis.ar@live.com> * chore: fix lint errors --------- Co-authored-by: rahulkeswani101 <rahul@signoz.io>
* feat: tt api for new trace tables * fix: remove print and use correct context * fix: update var name
* feat: trace v4 inital commit * fix: add remaining files * fix: integrate with querier * fix: get trace by id api updated * fix: add servicename resource filter * fix: tests * fix: use correct prepQUery * fix: services page * fix: minor fixes to use the new table in api's and querier * fix: add support for window based pagination * feat: support for faster trace detail * fix: searchTraces * fix: attribute enrichment updated and issue in group by * fix: issues in group by * fix: enrichment using alias * fix: test file added * fix: tests * fix: group by with filters * fix: add subquery * fix: trigger builde * fix: update pagination logic and few ch column names * fix: update qb * fix: add tests * feat: minor fixes * fix: update pagination logic * fix: update pagination logic * fix: remove utils * fix: remove unwanted API's * fix: attribute and attribute values v2 * fix: autocomplete api's updated * fix: tests fixed * feat: minor fixes * fix: update telemetry functions * fix: dont use alias, use proper col names * fix: move models to it's own file * fix: minor fixes * fix: address comments * fix: add to serviceoverview function * fix: add changes to overview function * fix: address comments * fix: remove printlines --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…shboard list table (#6496)
* fix: pie chart should not have padding between adjacent items * fix: remove the labels which do not have any data
* fix: add v2 for getServices and GetTopOperations * fix: add comments * fix: update logic for filters --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…6517) * fix: add settings to allow distributed_product_mode for trace panel * fix: tests fixed * fix: add 10gb memory limit --------- Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
* chore: move all the usages of license v2 to license v3 * chore: added log lines for debugging
* chore: qs: logs pipeline preview: use collectorsimulator from signoz-otel-collector * chore: qs: remove collectorsimulator: located in signoz-otel-collector now
…1.13 Signed-off-by: Prashant Shahi <prashant@signoz.io>
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 7cd8442 in 3 minutes and 39 seconds
More details
- Looked at
9592
lines of code in135
files - Skipped
3
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. pkg/query-service/app/clickhouseReader/reader.go:1058
- Draft comment:
Check for errors returned byr.db.QueryRow
to ensure any issues are handled appropriately. - Reason this comment was not posted:
Comment did not seem useful.
2. pkg/query-service/app/inframetrics/hosts.go:373
- Draft comment:
Check for errors returned byGetCountOfThings
to ensure proper error handling. - Reason this comment was not posted:
Comment did not seem useful.
3. pkg/query-service/app/clickhouseReader/reader.go:708
- Draft comment:
Consider usingzap.L().Warn
instead ofzap.L().Error
for non-critical issues to avoid alarming logs for expected conditions. - Reason this comment was not posted:
Confidence changes required:50%
The code is usingzap.L().Error
to log errors, but it should usezap.L().Warn
for non-critical issues. This is a common pattern in the codebase, so it should be addressed in multiple places.
4. frontend/src/components/HostMetricsDetail/HostMetricsDetail.styles.scss:1
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets or styled components instead. This is applicable inHostMetricsDetail.styles.scss
and other similar files. - Reason this comment was not posted:
Comment was on unchanged code.
5. frontend/src/container/HostMetricsLoading/HostMetricsLoading.tsx:14
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Marked as duplicate.
6. frontend/src/container/HostMetricsLoading/HostMetricsLoading.tsx:15
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Marked as duplicate.
7. frontend/src/components/HostMetricsDetail/Containers/Containers.tsx:18
- Draft comment:
Avoid using inline styles in React components. Use external stylesheets, CSS classes, or styled components instead. This is also applicable inProcesses.tsx
. - Reason this comment was not posted:
Marked as duplicate.
8. frontend/src/components/HostMetricsDetail/HostMetricsDetails.tsx:481
- Draft comment:
Avoid using inline styles. Use external stylesheets or styled components instead. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_bgvtEcaa5gjyusvB
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Important
Update SigNoz to v0.60.0 with new trace schema support, enhanced telemetry, and infrastructure monitoring features.
docker-compose.yaml
and other Docker setup files.UseTraceNewSchema
flag inapi.go
,server.go
, andreader.go
to support new trace schema.SearchTraces
intraces.go
to handle new trace API.GetServices
andGetTopOperations
inreader.go
to support new schema.telemetry.go
.AppRoutes
andInfraMonitoring.json
.HostMetricsDetail
.logparsingpipeline/preview.go
.ValidateAndCastValue
informat.go
to handle string arrays.This description was created by for 7cd8442. It will automatically update as commits are pushed.