-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix softdepend warning about GriefPrevention #3716
Merged
FranKusmiruk
merged 20 commits into
SkriptLang:master
from
TheDGOfficial:fix-softdepend-warning
Mar 4, 2021
Merged
Fix softdepend warning about GriefPrevention #3716
FranKusmiruk
merged 20 commits into
SkriptLang:master
from
TheDGOfficial:fix-softdepend-warning
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y returning main hand (SkriptLang#3586)
…a couple addons (SkriptLang#3625) - This provides a constructor that matches the original constructor before the recent changes
…cation function (SkriptLang#3607) - Also added a few more examples since people find this hard to understand
* Enhance portal events * Add version check for PortalCreateEvent event-entity
# Conflicts: # src/main/java/ch/njol/skript/events/SimpleEvents.java # src/main/java/ch/njol/skript/expressions/ExprExperience.java
* Apply new line in item lore * Add test case for item with lore * Remove needless clone() * fix test case of item with lore * Use Expression#stream instead of Arrays.stream
…r/script load/unload events (SkriptLang#3634) * BukkitEventValues - add support for command sender (console) in server load/stop and script load/unload events - this allows for using the send effect in these events without using `to console` * BukkitEventValues - change arg -> e (for consistency sake)
ShaneBeee
previously approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
ShaneBeee
added
2.5
bug
An issue that needs to be fixed. Alternatively, a PR fixing an issue.
labels
Jan 30, 2021
APickledWalrus
previously approved these changes
Mar 1, 2021
FranKusmiruk
dismissed stale reviews from APickledWalrus and ShaneBeee
March 4, 2021 13:48
The base branch was changed.
FranKusmiruk
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this warning:
[22:52:38] [Server thread/WARN]: [Skript] Loaded class me.ryanhamshire.GriefPrevention.Claim from GriefPrevention v16.17.1 which is not a depend, softdepend or loadbefore of this plugin.
It should happen only when GriefPrevention is installed and just a warning, that doesn't mean it shouldn't be fixed though.
Target Minecraft Versions: any
Requirements: none
Related Issues: none