Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix softdepend warning about GriefPrevention #3716

Merged
merged 20 commits into from
Mar 4, 2021

Conversation

TheDGOfficial
Copy link
Contributor

Description

Fixes this warning:

[22:52:38] [Server thread/WARN]: [Skript] Loaded class me.ryanhamshire.GriefPrevention.Claim from GriefPrevention v16.17.1 which is not a depend, softdepend or loadbefore of this plugin.

It should happen only when GriefPrevention is installed and just a warning, that doesn't mean it shouldn't be fixed though.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

ShaneBeee and others added 18 commits December 1, 2020 07:31
…a couple addons (SkriptLang#3625)

- This provides a constructor that matches the original constructor before the recent changes
…cation function (SkriptLang#3607)

- Also added a few more examples since people find this hard to understand
* Enhance portal events

* Add version check for PortalCreateEvent event-entity
# Conflicts:
#	src/main/java/ch/njol/skript/events/SimpleEvents.java
#	src/main/java/ch/njol/skript/expressions/ExprExperience.java
* Apply new line in item lore

* Add test case for item with lore

* Remove needless clone()

* fix test case of item with lore

* Use Expression#stream instead of Arrays.stream
…r/script load/unload events (SkriptLang#3634)

* BukkitEventValues - add support for command sender (console) in server load/stop and script load/unload events
- this allows for using the send effect in these events without using `to console`

* BukkitEventValues - change arg -> e (for consistency sake)
@ShaneBeee ShaneBeee changed the base branch from master to dev-2.5 January 30, 2021 06:32
ShaneBeee
ShaneBeee previously approved these changes Jan 30, 2021
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ShaneBeee ShaneBeee added 2.5 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Jan 30, 2021
APickledWalrus
APickledWalrus previously approved these changes Mar 1, 2021
@FranKusmiruk FranKusmiruk changed the base branch from dev-2.5 to master March 4, 2021 13:48
@FranKusmiruk FranKusmiruk dismissed stale reviews from APickledWalrus and ShaneBeee March 4, 2021 13:48

The base branch was changed.

@FranKusmiruk FranKusmiruk merged commit 885a4b6 into SkriptLang:master Mar 4, 2021
@TheDGOfficial TheDGOfficial deleted the fix-softdepend-warning branch April 12, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants