Crash when going fullscreen (especially Android TVs)

[dolorosus]

Checklist

• I am able to reproduce the bug with the latest version.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

v0.24.0

Steps to reproduce the bug

1. Start any video and try to switch to fullscreen mode results in an error message (see screenshot).
2. No chance to continue the video, 'cause only an remote control is attached, but got no focus to the play button. Only chance is going back and restart the video which brings us back 1.

Expected behavior

entering fullscreen mode

Actual behavior

see attached [screenshot]

Screenshots/Screen recordings

Logs

No response

Affected Android/Custom ROM version

AndroidTV 9 and FireTV

Affected device model

No response

Additional information

No response

[opusforlife2]

Thank you. Being polite never killed anyone.

[opusforlife2]

The screenshot you've posted is of the toast. Can you check your notifications to fetch the actual error?

[dolorosus]

I know the screenshot give no useful information, but how should I access notifications AndroidTV?

[opusforlife2]

Okay, it seems like providing app notifications on Android TV is a no-no: https://scribe.rip/android-tv-application-notifications-on-o-c6820ada2086

@Stypox Can it be made so that errors which would generate error notifications on handhelds are made to open the error activity on TV instead?

[j-seeley]

Same issue on Android TV. Videos in non-full screen play fine in v0.24 but when clicking on the full screen icon, the screen is filled with green except the video window stays the same size. At that point, the video freezes, but the audio continues. When I back out of full screen, it then crashes. (previous recent versions of NewPipe worked well with no issues)



I don't have time right now to figure out how to submit this report in live text format from Android TV, so I made some screenshots for now.

[fliegentoeter]

Same Issue on a FireTV 4K stick. Videos do not open in Fullscreen and when manually clicking on Full-Screen newpipe crashes...

[migbox]

I have the same issue on Sony Android TV., now I reinstalled the 23.3 version, that works.
may I suggest to add a shortcut to switch into/out of fullscreen that can be used from a tv remote?

[opusforlife2]

may I suggest to add a shortcut to switch into/out of fullscreen that can be used from a tv remote?

Is the full screen button non-selectable or invisible?

[dolorosus]

I have the same issue on Sony Android TV., now I reinstalled the 23.3 version, that works. may I suggest to add a shortcut to switch into/out of fullscreen that can be used from a tv remote?

I'm afraid that won't help. As soon as you switch to full screen mode, you get an error message. After that, no further operation is possible, because none of the controls get the focus anymore.

It would make more sense to eliminate the cause.
in versions <23.0 it worked, only since V23.0 there are problems with the fullscreen mode.

[fliegentoeter]

What i've learned on AndroidTV: Do not update newpipe when everything is working, wait until youtube makes changes and you are forced to update :)
Same goes for a lot of other apps that are simply not designed for AndroidTV...

[opusforlife2]

What i've learned on AndroidTV: Do not update newpipe when everything is working, wait until youtube makes changes and you are forced to update :)
Same goes for a lot of other apps that are simply not designed for AndroidTV...

What your actual learning should be is that you should help us test upcoming changes on your TV device so that our entire TV userbase doesn't have to suffer when a new version is released.

No one in the dev team has an Android TV. If no user steps up to help test, then issues like this are bound to come up again and again.

[migbox]

I will be glad to do tests on your behalf. The Sony Android TV has been the best TV I ever bought, I strongly recommend it to people who need to buy a new tv

[dolorosus]

... No one in the dev team has an Android TV. If no user steps up to help test, then issues like this are bound to come up again and again.

Maybe you should go a little bit more into detail how to get a test version?

[fliegentoeter]

I get that. But I have no idea how to test these versions and/or install them with a regular newpipe version installed.
It is quite complicated to downgrade by itself and copy/import my old settings with only a remote control by itself.
So my solutuion is simply to run the version until something breaks and upgrade then when I have to.
There are no notifications, so I do not even get a notice when a new version would be available in Neo-Store (only Fdroid-Store I found usable with a remote control).
As mentioned before, the old v23 from fdroid works great.

[opusforlife2]

I will be glad to do tests on your behalf.

@migbox Shall I add your name to https://github.com/TeamNewPipe/NewPipe/wiki/Testers#android-tv?

Maybe you should go a little bit more into detail how to get a test version?

@dolorosus At the bare minimum, we need our release candidates tested to catch any regressions (bugs that are not present in the current release, but were added by new changes since then). You can grab these from the "RC [version number]" issues that we pin for at least a week before releasing a new version, precisely for this reason.

Apart from that, every PR that could possibly affect TV users should be tested. For the most part, this includes PRs that affect the player code. The PR description has a "testing" section which describes how to obtain the needed debug APKs for this.

But I have no idea how to test these versions and/or install them with a regular newpipe version installed.

@fliegentoeter Stypox did some magic years ago which lets you install several different versions of Newpipe side by side with the current release. The APKs you download from different PRs or from the RC issues have separate package names. This means that if you have 2 APKs from 2 different PRs, they will install side-by-side. But if you download a newer APK from one of the PRs, one of the 2 APKs will get updated. This means you can continue to test newer changes in PRs as they get updated, and also that you can test multiple PRs in parallel.

You should never need to touch your official release version for any reason. One of our developers used to keep a record 60+ Newpipe builds on their device at a time.

And there is no need at all to import/export anything. You should definitely keep a database export of your current release build as a safety net in any case. Just make sure to never mess with database backups with development builds, because any changes there could potentially corrupt your "true" database of the release version.

[elparra72]

I confirm this version runs in Xiaomi P1 TV. An error appears when application starts in the bottom of the screen but it dissapears in 2 seconds. I can see any video in full screen mode but open a video in full screen by default option does not work. Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>

…

________________________________ From: somos61 ***@***.***> Sent: Thursday, February 2, 2023 2:39:38 PM To: TeamNewPipe/NewPipe ***@***.***> Cc: elparra72 ***@***.***>; Comment ***@***.***> Subject: Re: [TeamNewPipe/NewPipe] Crash when going fullscreen (especially Android TVs) (Issue #9023) i'd say, we're moving right direction. At last, i have no crash, even no err.msg switching fullscreen, from portrait to landscape and back. Also going from mini to popup during playback, from popup to background and back is fine as well. The only thing i've noticed, if i change resolution on the fly, it blacken the screen for a couple of seconds and then continues, but i hear audio is still playing. Anyway, thanks for your work guys, great! 👍 — Reply to this email directly, view it on GitHub<#9023 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A34HU7P2V3RAIDRE6RDQTADWVO2JVANCNFSM6AAAAAAQVGWPY4>. You are receiving this because you commented.Message ID: ***@***.***>

[dolorosus]

What about this? It is based on the latest commit on the dev-v2 branch of exoplayer (which doesn't crash my phone anymore), with a modification that makes it so that deviceNeedsSetOutputSurfaceWorkaround is always true. app-debug.zip

On Philips (androidTV 9) switching to fullscreen results in a black screen.

[disconnect5852]

For me on xiaomi stick, i set to open in full screen. The first video i choosed opened in normal window, then switched to full screen, where the screen was black, but the sound worked. Then back, choose another video, it opened in fullscreen, and i could watch it till its end. But when i choose another video, i got "error see notifications" everytime i tried again Stypox ***@***.***> ezt írta (időpont: 2023. jan. 29., V 21:34):

…

What about this? It is based on the latest commit on the dev-v2 branch of exoplayer (which doesn't crash my phone anymore), with a modification that makes it so that deviceNeedsSetOutputSurfaceWorkaround is always true. app-debug.zip <https://github.com/TeamNewPipe/NewPipe/files/10530774/app-debug.zip> — Reply to this email directly, view it on GitHub <#9023 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5TLF2EZFOYZU2UYRJGAILWU3H33ANCNFSM6AAAAAAQVGWPY4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[JPluess]

Have the same issue here.

I could get an error maybe this helps

[srad]

Just tested version 0.25.0 on Firestick 4k Max, when I click the fullscreen button it instantly crashes. Only playing the small window is possible.

[NeloKa61]

Testing 0.25.0 when playing video it first crash but when i click play again it play normally but when clicked minimizes it crashed and cannot return to fullscreen playback device B860H v5.0
Default setting MPEG4 except start playback on fullscreen ticked on

[Stypox]

Stop writing the same comment hundreds of times. We know what the issue is, as the title of this issue says, so there is no need to write it again multiple times. And some people also captured the stack trace multiple times, so there is no need to capture it again (unless you find some differences or you are testing an APK some team member has sent).

[TobiGr]

@ROBYER1 @somos61 @dolorosus and to everyone who is getting black screen while playing videos, please check out #8829 (comment)

[agnel18]

Hello I'm having the same issue Not Working in Full Screen Mode on my Sony Bravia KD-65X82L.
When I open a video and click on the full screen button - I get an error stating to look at the notifications but,
Im not sure how to access the error notifications.
I can help as a test subject.
Version 26.1

[opusforlife2]

@agnel18 Open a new issue.