Disable media tunneling by default on known unsupported devices

[TobiGr]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

In #8875 a setting to disable media tunneling was added. However, the info on devices which do not support media tunneling was removed. That info is re-added and used to disable media tunneling on those devices by default.

Disabling media tunneling seems to also fix the full screen enter/exit bug on Android TVs (#9023)

New models added:

• Sony Bravia VH1 (BRAVIA_VH1)
• Sony Bravia VH2 (BRAVIA_VH2), e.g. model A90J
• Sony Bravia Android TV platform 2 (BRAVIA_ATV2)
• Sony Bravia Android TV platform 3 4K (BRAVIA_ATV3_4K)
• Phillips 4K (O)LED TV (PH7M_EU_5596)
• Panasonic 4KTV-JUP (TX_50JXW834)
• Bouygtel4K (Bouygues Telecom Bbox 4K) (HMB9213NW)

Other changes:

• Added info to ExoPlayer settings explaining that media tunneling was disabled automatically.

Media tunneling setting screenshot

Fixes the following issue(s)

• Fixes Add an ExoPlayer settings page #8875 (comment)
• Fixes Android TV - No video/black screen #8829
• Fixes Crash when going fullscreen (especially Android TVs) #9023

ToDo

• Rework applying device detection results and restoring that info correctly from a backup.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[TobiGr]

I wanted to wait on feedback from #8829 and #10112 to include more devices, however there is no response.

[peat80]

BRAVIA_VH2 should be added to this list.

[TobiGr]

@peat80 which android version is it running?

[peat80]

I believe the tv runs android tv 10.

[TobiGr]

@peat80 Please test the APK (see PR description). I hope that everything works as expected. If it does not, please go to the settings > debug and use on of the options which crash the app and show the error screen. The crash info does contain information on your Android version. If it is Android 10 / SDK level 29, go into the video & audio settings > ExoPlayer settings and check whether the option "Disable media tunneling" is enabled. If it is not enabled, enable it and try to play a video.

[peat80]

Back home now. Can confirm tv indeed runs on android 10. The downloded artifact apk has media tunneling disabled per default now and works. 😀👌

[peat80]

BRAVIA_VH1 should probably also be added.

There was a closed PR for that:

#9425

[pihug12]

I don't suffer the "no video / black screen" problem, but disabling "media tunneling" with this APK solves the fullscreen problem for me.

• Model: Bouygtel4K (Bouygues Telecom Bbox 4K)
• Android TV 9 (build "Californie")
• Device ID: HMB9213NW

I don't know if the device should be added to this list or not?

[TobiGr]

@pihug12 I disabled it in case there are other people using the same device.

[AudricV]

Your changes look mostly good to me, however, I think we should use a complete different approach instead of DB migrations, by using an app preference containing with which version of the app the media tunneling check has been ran and run the check with each NewPipe update.

With this value, we can check if the version matches the current one installed + use some logic with the two preferences storing whether the device has been whitelisted automatically and media tunneling has been enabled by user, in order to know if we need to disable automatically media tunneling or not.

This approach should make maintenance less hard than doing a lot of database migrations every time we add a new device.

Could you also format better and improve your method Javadocs? For instance, you are using line returns to separate titles and descriptions, but they are ignored, so you should also use paragraph elements in this case.

[Ang-le]

Device ID: BRAVIA_ATV2
I just tried it and it worked for me in full screen Disable media tunneling.

Thank you

[TobiGr]

I added two new devices: BRAVIA_ATV2 and BRAVIA_ATV3_4K as requested by @Ang-le and @ROBYER1.
@AudricV I'll address your review during the next week. Thank you for clarifying what you meant by using preferences.

Outdated review

[Stypox]

I think a simple list preference with "Tunneling on, tunneling off, automatic" would have been simpler, since with the current code once you manually disable tunneling there is no way to go back to automatic mode. I think we can postpone this to a small PR after the release.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication