Add boolean for BRAVIA_VH1 & disable media tunneling support #9425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
AudricV
added
bug
|
Unfortunately, this approach is still device-specific and won't work for all devices, like that's currently the case. In order to avoid this effort in the future for other devices, I opened a pull request to add some ExoPlayer settings in NewPipe on every build type, which includes the ability to disable media tunneling for every device and removes this device-specific workaround/patch: see #8875. Therefore, I am closing this pull request. Thanks for your effort! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Restores the ability to go fullscreen on Sony Bravia HV1 smart TVs from 0.24.0+. Also fixes long standing issue that results in frequent crashes between videos.
Fixes the following issue(s)
APK testing
https://github.com/glbyers/NewPipe/raw/5447dfbdcaf1f6b8fd9e3a75bffea2a5025ac97d/app-debug.apk
Due diligence