Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable macOS CI builds, using macOS 12 and Xcode 13.4 #484

Merged
merged 1 commit into from
May 24, 2022
Merged

Reenable macOS CI builds, using macOS 12 and Xcode 13.4 #484

merged 1 commit into from
May 24, 2022

Conversation

ezraberch
Copy link
Member

Now that the macOS 12 image is available, the CI builds can be reenabled.

@ezraberch ezraberch added the continuous integration Changes related to the continuous integration process label May 23, 2022
MaxDesiatov
MaxDesiatov approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@ezraberch ezraberch merged commit 2e7f561 into main May 24, 2022
@ezraberch ezraberch deleted the macos12 branch May 24, 2022 09:07
@MaxDesiatov MaxDesiatov mentioned this pull request May 24, 2022
Merged
MaxDesiatov added a commit that referenced this pull request May 24, 2022
@MaxDesiatov
Revert "Add html5 doctype to static renderer (#486)" (#487)
a604ef5 
* Revert "Add html5 doctype to static renderer (#486)"

This reverts commit 3081f55 which causes failing layout snapshots we've recently turned back on in #484.

* Fix newlines inconsistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
continuous integration Changes related to the continuous integration process
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezraberch @MaxDesiatov