Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add html5 doctype to static renderer #486

Merged
merged 3 commits into from
May 24, 2022
Merged

Add html5 doctype to static renderer #486

merged 3 commits into from
May 24, 2022

Conversation

AndrewBarba
Copy link
Contributor

  • Add <!DOCTYPE html> to the top of static rendered pages

MaxDesiatov
MaxDesiatov approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label May 24, 2022
@MaxDesiatov MaxDesiatov merged commit 3081f55 into TokamakUI:main May 24, 2022
MaxDesiatov added a commit that referenced this pull request May 24, 2022
@MaxDesiatov
Revert "Add html5 doctype to static renderer (#486)"
5420aa8 
This reverts commit 3081f55.
MaxDesiatov added a commit that referenced this pull request May 24, 2022
@MaxDesiatov
Revert "Add html5 doctype to static renderer (#486)" (#487)
a604ef5 
* Revert "Add html5 doctype to static renderer (#486)"

This reverts commit 3081f55 which causes failing layout snapshots we've recently turned back on in #484.

* Fix newlines inconsistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewBarba @MaxDesiatov