Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add html5 doctype to static renderer (#486)" #487

Merged
merged 2 commits into from
May 24, 2022
Merged

Revert "Add html5 doctype to static renderer (#486)" #487

merged 2 commits into from
May 24, 2022

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented May 24, 2022 •
edited
Loading

This reverts commit 3081f55 which causes failing layout snapshots we've recently turned back on in #484.

@MaxDesiatov MaxDesiatov added bug Something isn't working continuous integration Changes related to the continuous integration process labels May 24, 2022
@ezraberch
Copy link
Member

The rest of the failing tests are from #483. Those are caused by an extra blank line after the title tag.

@MaxDesiatov
Copy link
Collaborator Author

Yep, I've just bisected it, resolving it now.

@MaxDesiatov MaxDesiatov marked this pull request as ready for review May 24, 2022 09:52
@MaxDesiatov
Copy link
Collaborator Author

CC @AndrewBarba

@MaxDesiatov MaxDesiatov merged commit a604ef5 into main May 24, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/revert-doctype branch May 24, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezraberch ezraberch ezraberch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working continuous integration Changes related to the continuous integration process
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @ezraberch