-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dmac26 I'm a little confused here. There already was a pull request that got merged in for this issue right here: #1289
This PR is addressing the same issue, but now the issue seems to also include the ability to use a slash character. That wasn't part of the other PR, and I presume it was added to the issue after the fact.
Even though it's pretty minor, to avoid scope creep I'd recommend we create a new separate issue to address the additional slash functionality.
Please also take a look at the following comment I've added to the original issue: #1213 (comment)
@briandavidson - Given that we will need to handle the bolded text issue on another card if Aquib wants to revert, is this one g2g? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g2g!
Summary
Addresses Issue #1213
This code update completes the 1213 card by updating all related .html, .ts, and .scss files to ensure that all numeric fields referenced in the 1213 card have their width reduced and validation updated to allow numeric ranges to be input with dashes included.
*** NOTE: This is the second iteration of this PR, adding additional functionality to the number-validation component to allow for the input of slashes by users
This pull request is ready to merge when...