Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

1213 resize number fields #1376

Merged
merged 6 commits into from
Jul 1, 2020
Merged

1213 resize number fields #1376

merged 6 commits into from
Jul 1, 2020

Conversation

Dmac26
Copy link
Contributor

@Dmac26 Dmac26 commented Jun 19, 2020

Summary

Addresses Issue #1213

This code update completes the 1213 card by updating all related .html, .ts, and .scss files to ensure that all numeric fields referenced in the 1213 card have their width reduced and validation updated to allow numeric ranges to be input with dashes included.

*** NOTE: This is the second iteration of this PR, adding additional functionality to the number-validation component to allow for the input of slashes by users

This pull request is ready to merge when...

  • Feature branch starts with the issue number
  • Is connected to its original issue via zenhub 👇
  • All tests are passing and meet coverage, linting, and accessibility requirements. And no security vulnerabilities ⚫️(Circle)
  • This code has been reviewed by someone other than the original author

Copy link
Member

@briandavidson briandavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dmac26 I'm a little confused here. There already was a pull request that got merged in for this issue right here: #1289

This PR is addressing the same issue, but now the issue seems to also include the ability to use a slash character. That wasn't part of the other PR, and I presume it was added to the issue after the fact.

Even though it's pretty minor, to avoid scope creep I'd recommend we create a new separate issue to address the additional slash functionality.

Please also take a look at the following comment I've added to the original issue: #1213 (comment)

@Dmac26
Copy link
Contributor Author

Dmac26 commented Jun 23, 2020

@briandavidson - Given that we will need to handle the bolded text issue on another card if Aquib wants to revert, is this one g2g?

@Dmac26 Dmac26 removed the request for review from mtlaney June 23, 2020 15:44
@Dmac26 Dmac26 requested a review from mtlaney June 29, 2020 16:12
Copy link
Member

@briandavidson briandavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g!

@Dmac26 Dmac26 merged commit b509399 into dev Jul 1, 2020
@abdul-fs abdul-fs mentioned this pull request Jul 2, 2020
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants