Change BrainParametersProto to support ActionSpec #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Oct 19, 2020
| message BrainParametersProto { | ||
| reserved 1; // deprecated int32 vector_observation_size = 1; | ||
| reserved 2; // deprecated int32 num_stacked_vector_observations = 2; | ||
| repeated int32 vector_action_size = 3; | ||
| repeated int32 vector_action_size_deprecated = 3; // mark as deprecated in communicator v0.22.0 |
There was a problem hiding this comment.
v1.3.0 (that's the one from https://github.com/Unity-Technologies/ml-agents/pull/4576/files)
chriselion
approved these changes
Oct 19, 2020
delete-merged-branch
bot
deleted the
develop-hybrid-actions-csharp-actionspec
branch
dongruoping
added a commit
that referenced
this pull request
Dec 4, 2020
* Add hybrid action capability flag (#4576) * Change BrainParametersProto to support ActionSpec (#4579) * Assign new BrainParametersProto fields based on capabilities (#4581) * ActionBuffer with hybrid actions for RemotePolicy (#4592) * Barracuda inference for hybrid actions (#4611) * Refactor BarracudaModel loader checks (#4629) * Export separate nodes for continuous/discrete actions (#4655) * Separate continuous/discrete actions in AgentActionProto (#4698) * Force different nodes for new and deprecated action output (#4705)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Change BrainParametersProto to support ActionSpec.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
JIRA link: MLA-1315
Types of change(s)
Checklist
Other comments