Separate continuous/discrete actions in AgentActionProto #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
reviewed
Dec 2, 2020
chriselion
reviewed
Dec 2, 2020
| foreach (var ap in proto.Value) | ||
| { | ||
| agentActions.Add(ap.VectorActions.ToArray()); | ||
| agentActions.Add(new ActionBuffers(ap.ContinuousActions.ToArray(), ap.DiscreteActions.ToArray())); |
There was a problem hiding this comment.
Not quite sure what type ap is here, but can we add a ToActionBuffers() extension method to it?
There was a problem hiding this comment.
It is auto-generated AgentActionProto class so maybe not
There was a problem hiding this comment.
extension method == "this" modifier in argument, so something like
public static ActionBuffers ToActionBuffers(this UnityRLInputProto.Types.AgentActionProto proto)
{
return new ActionBuffers(proto.ContinuousActions.ToArray(), proto.DiscreteActions.ToArray());
}
...
agentActions.Add(ap.ToActionBuffers());
...There was a problem hiding this comment.
not a big deal but it's just a bit cleaner
chriselion
reviewed
Dec 2, 2020
| } | ||
|
|
||
| public void CopyActions(ActionBuffers actionBuffers) | ||
| { | ||
| actionBuffers.PackActions(storedVectorActions); |
There was a problem hiding this comment.
Do we use PackActions anywhere else? If not, can we remove it?
chriselion
approved these changes
Dec 2, 2020
surfnerd
approved these changes
Dec 2, 2020
Can you point out where the syntax errors are? I didn't see python syntax issues around VectorActionsDeprecated |
around line 586 in the execution log. |
dongruoping
added a commit
that referenced
this pull request
Dec 4, 2020
* separate entries for continuous/discrete in action proto * store actions in AgentInfo as ActionBuffers instead of arrays
dongruoping
added a commit
that referenced
this pull request
Dec 4, 2020
* Add hybrid action capability flag (#4576) * Change BrainParametersProto to support ActionSpec (#4579) * Assign new BrainParametersProto fields based on capabilities (#4581) * ActionBuffer with hybrid actions for RemotePolicy (#4592) * Barracuda inference for hybrid actions (#4611) * Refactor BarracudaModel loader checks (#4629) * Export separate nodes for continuous/discrete actions (#4655) * Separate continuous/discrete actions in AgentActionProto (#4698) * Force different nodes for new and deprecated action output (#4705)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
vector_actionsas deprecated but still keep it for backward compatibility.storedVectorActionsfrom arrays to ActionBuffers to store hybrid actions in AgentInfoUseful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
JIRA: MLA-1593
Types of change(s)
Checklist
Other comments