-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using addQueryArgs to generate Manage All Reusable Blocks link #13653
Conversation
# Conflicts: # packages/edit-post/src/components/header/more-menu/index.js # packages/editor/src/components/inserter/menu.js
I can't approve my own PR but this is something that I opened to land #10065 which I approved already ... |
Thanks, @SofiaSousa for your contribution 💯 If you feel like we should further abstract all WordPress urls, I'm happy to discuss next steps. |
It's unclear between this and #10065: Why is this change necessary? |
Let me copy a #10065 (comment) from @SofiaSousa:
this is in the context of Gutenberg in Drupal. I think we should further abstract all WordPress links in the follow-up PR. They are now included in |
Gotcha, sorry I missed the comment in the other pull request. I agree, for this purpose (and even for WP's own maintainability), the links ought to be created more abstractly. In this example, I could imagine a function like |
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Make the modal title styling consistent (#13669) Disable navigation block for text mode. (#12185) Fix: Linting problem in modal example code (#13671) Add myself as a code owner to the annotations (#13672) Add more reviewers to CODEOWNERS.md file (#13667) Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576) Workflow: Add repository CODEOWNERS file (#13604) Add a mobile minimum size for form fields (#13639) Update edit-save documentation (#13578) Alt image setting (#13631) Fix: Allow years lower than 1970 in DateTime component. (#13602) Using addQueryArgs to generate Manage All Reusable Blocks link (#13653) Bump plugin version to 5.0.0-rc.1 (#13652) Update lodash to 4.17.10 (#13651) Refreshed PR (#9469) Set default values of the width and height input fields according to the actual image dimensions (#7687) 12647 fix css color picker (#12747) Remove "we" from messages (#13644) Fix: Font size picker max width on mobile (#13264) Fix/issue 12501 menu item aria label ...
* feat: Use addQueryArgs to generate Manage All Reusable Blocks link * feat: Use addQueryArgs to generate Manage All Reusable Blocks link (forgotten file) * feat: Use addQueryArgs to generate Manage All Reusable Blocks link * fix: Import missing addQueryArgs method * chore: Update package-lock after run npm@6.7 install
* feat: Use addQueryArgs to generate Manage All Reusable Blocks link * feat: Use addQueryArgs to generate Manage All Reusable Blocks link (forgotten file) * feat: Use addQueryArgs to generate Manage All Reusable Blocks link * fix: Import missing addQueryArgs method * chore: Update package-lock after run npm@6.7 install
Description
Copied over from #10065. Props to @SofiaSousa for all work done on this PR.
Using
addQueryArgs
method from@wordpress/url
instead of hand coding 'Manage All Reusable Blocks' link.How has this been tested?
edit.php?post_type=wp_block
.edit.php?post_type=wp_block
.Screenshots
Types of changes
Reuse an existing method.
Checklist: