Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the modal title styling consistent #13669

Merged

Conversation

jorgefilipecosta
Copy link
Member

Description

Fixes: #13650

In core, we used different and inconsistent modal styles. The resolve modal used the default modal styles, and the keyboard shortcuts and options modals added a span in the title and used a custom version of the title styles (repeating each other).

This PR makes the title styles used by options and keyboard shortcuts modal then default ones making sure plugins can benefit from these styles and removing duplicate code.

Before:
screenshot 2019-02-05 at 12 58 10

After:
screenshot 2019-02-05 at 12 57 49

How has this been tested?

I added the following content in the code-editor:

<!-- wp:paragraph -->
<ps>ssdfds</p>
<!-- /wp:paragraph -->

I switched to visual mode pressed the resolve button and verified the new styles were applied.
I checked the options and keyboard shortcut modals continue to work as before.

gziolo
gziolo previously requested changes Feb 5, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests need to be refreshed. Otherwise, those changes look great. Nice code cleanup 👍

@gziolo gziolo added [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement. [Type] Code Quality Issues or PRs that relate to code quality labels Feb 5, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 5, 2019
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, this looks good. Thanks @jorgefilipecosta.

@jorgefilipecosta jorgefilipecosta force-pushed the update/make-the-modal-title-styling-consistent branch from 8054b31 to f43f320 Compare February 5, 2019 14:29
@jorgefilipecosta jorgefilipecosta dismissed gziolo’s stale review February 5, 2019 15:00

The snapshots were updated

@jorgefilipecosta jorgefilipecosta merged commit 1653adf into master Feb 5, 2019
@jorgefilipecosta jorgefilipecosta deleted the update/make-the-modal-title-styling-consistent branch February 5, 2019 15:22
daniloercoli added a commit that referenced this pull request Feb 5, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Make the modal title styling consistent (#13669)
  Disable navigation block for text mode. (#12185)
  Fix: Linting problem in modal example code (#13671)
  Add myself as a code owner to the annotations (#13672)
  Add more reviewers to CODEOWNERS.md file (#13667)
  Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576)
  Workflow: Add repository CODEOWNERS file (#13604)
  Add a mobile minimum size for form fields (#13639)
  Update edit-save documentation  (#13578)
  Alt image setting (#13631)
  Fix: Allow years lower than 1970 in DateTime component. (#13602)
  Using addQueryArgs to generate Manage All Reusable Blocks link (#13653)
  Bump plugin version to 5.0.0-rc.1 (#13652)
  Update lodash to 4.17.10 (#13651)
  Refreshed PR (#9469)
  Set default values of the width and height input fields according to the actual image dimensions (#7687)
  12647 fix css color picker (#12747)
  Remove "we" from messages (#13644)
  Fix: Font size picker max width on mobile (#13264)
  Fix/issue 12501 menu item aria label
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the modal title styling consistent
3 participants