Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Establish consistency regarding alignment options between the archives and categories blocks #9469

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

nfmohit
Copy link
Member

@nfmohit nfmohit commented Aug 30, 2018

Description

This PR closes #9413 which suggests the sync up of alignment options in the archives and categories blocks. This removes the "Full" alignment option from the categories block so it stays consistent with the archives block.

How has this been tested?

This PR has been tested by going through the following steps:

  1. Started a new post using the Gutenberg editor.
  2. Added the "Categories" block.
  3. Made sure that the "Full" alignment option doesn't show up in the block alignment toolbar.

Screenshots

pull-9413

Types of changes

This PR just removes the full option from the controls parameter that defined the alignment options in the "Categories" block.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

This PR needs to be updated to work with the current implementation of Category block.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@ZebulanStanphill
Copy link
Member

@gziolo I made a PR that syncs the alignment options of the blocks and also does some code cleanup: #10706

@nfmohit
Copy link
Member Author

nfmohit commented Jan 27, 2019

Thank you for the heads-up @gziolo, a refresh is coming up real soon ❤️

@gziolo gziolo added [Block] Categories Affects the Categories Block [Type] Enhancement A suggestion for improvement. labels Jan 28, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Jan 28, 2019
@nfmohit
Copy link
Member Author

nfmohit commented Feb 2, 2019

PR refreshed, thank you for the review @gziolo ❤️

@gziolo gziolo merged commit a0dcbfa into WordPress:master Feb 4, 2019
@gziolo
Copy link
Member

gziolo commented Feb 4, 2019

@nfmohit-wpmudev thanks for waiting so long to get this PR merged. It should never happen given how easy to reviews this change was. I really appreciate your willingness to refresh this PR so quickly 🥇

@nfmohit
Copy link
Member Author

nfmohit commented Feb 5, 2019

Thank you for the merge and for your kind words @gziolo ❤️

daniloercoli added a commit that referenced this pull request Feb 5, 2019
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Make the modal title styling consistent (#13669)
  Disable navigation block for text mode. (#12185)
  Fix: Linting problem in modal example code (#13671)
  Add myself as a code owner to the annotations (#13672)
  Add more reviewers to CODEOWNERS.md file (#13667)
  Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576)
  Workflow: Add repository CODEOWNERS file (#13604)
  Add a mobile minimum size for form fields (#13639)
  Update edit-save documentation  (#13578)
  Alt image setting (#13631)
  Fix: Allow years lower than 1970 in DateTime component. (#13602)
  Using addQueryArgs to generate Manage All Reusable Blocks link (#13653)
  Bump plugin version to 5.0.0-rc.1 (#13652)
  Update lodash to 4.17.10 (#13651)
  Refreshed PR (#9469)
  Set default values of the width and height input fields according to the actual image dimensions (#7687)
  12647 fix css color picker (#12747)
  Remove "we" from messages (#13644)
  Fix: Font size picker max width on mobile (#13264)
  Fix/issue 12501 menu item aria label
  ...
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync up alignment options for the Archives and Categories blocks
4 participants