Patterns: Add missing decoding entities processing in Patterns and Template/Parts pages #52449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
t-hamano
commented
Jul 9, 2023
Comment on lines
-38
to
+37
| title: templatePart.title.rendered, | ||
| title: decodeEntities( templatePart.title.rendered ), |
There was a problem hiding this comment.
Decoding here eliminates the need for separate decoding in the lower-layer components. This is consistent with the fact that reusableBlockToPattern in the same file uses title.raw as the value of the title property.
t-hamano
commented
Jul 9, 2023
Comment on lines
-72
to
+76
| <MenuItem | ||
| onClick={ () => { | ||
| setIsModalOpen( true ); | ||
| setTitle( template.title.rendered ); | ||
| } } | ||
| > | ||
| <MenuItem onClick={ () => setIsModalOpen( true ) }> |
There was a problem hiding this comment.
I think there is no need to call setState() again when opening a popover, so I removed it.
There was a problem hiding this comment.
I believe this was set in #36879 so that unsaved changes wouldn't persist when closing and reopening the modal. It's a bit of an edge case, but if you make changes, click cancel, and then click "rename" again (without closing and reopening the parent menu of the "rename" button), you'll see the unsaved changes have been kept.
t-hamano
added
[Type] Bug
92 tasks
t-hamano
added
the
Backport to WP 6.7 Beta/RC
…mplate/Parts pages
ramonjd
force-pushed
the
fix/template-rename-actions
branch
from
e424f0d
to
e95bc0b
Compare
|
Flaky tests detected in e95bc0b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5504194712
|
Comment on lines
-72
to
+76
| <MenuItem | ||
| onClick={ () => { | ||
| setIsModalOpen( true ); | ||
| setTitle( template.title.rendered ); | ||
| } } | ||
| > | ||
| <MenuItem onClick={ () => setIsModalOpen( true ) }> |
There was a problem hiding this comment.
I believe this was set in #36879 so that unsaved changes wouldn't persist when closing and reopening the modal. It's a bit of an edge case, but if you make changes, click cancel, and then click "rename" again (without closing and reopening the parent menu of the "rename" button), you'll see the unsaved changes have been kept.
|
I just cherry-picked this PR to the update/beta-4-second-round branch to get it included in the next release: 1219af6 |
tellthemachines
pushed a commit
that referenced
this pull request
Jul 10, 2023
…mplate/Parts pages (#52449)
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
|
Question: this kind of bug happens a lot. It's very easy for a developer to miss. Should we consider adding a standardised way to get the "display safe" title of an entity? |
Can this problem be solved by making it so that when displaying the The description of the raw property states: |
I think the tendency to use |
tellthemachines
added a commit
that referenced
this pull request
Jul 11, 2023
* Post and Comment Template blocks: Change render_block_context priority to 1 (#52364) * Footnotes: fix lingering format boundary attr (#52439) * Footnotes: Fix incorrect anchor position in Firefox (#52425) * Scope CSS rules for the wp admin reset to js support only. (#52376) * Fix: Patterns & template parts: remove "apply globally" option from block settings (#52160) * Advanced styles panel: add an early return * Update index.js * Minor styling changes * Use array of features --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> * make the body of the editor minimmum viewport height so that smaller contents maintain clickability (#52406) * Patterns: Add renaming, duplication, and deletion options (#52270) * Patterns: Update manage pattern links to go to site editor if available (#52403) * [Patterns] Separate sync status into a filter control (#52303) Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Glen Davies <glen.davies@automattic.com> * Patterns: Add missing decoding entities processing in Patterns and Template/Parts pages (#52449) * Fix document title icon appearance (#52424) * Quote block: Add transform to paragraph (#51809) * Add ungroup transform as transform to p * Lint * Update test and snapshot. --------- Co-authored-by: Juan Aldasoro <juanfraa@gmail.com> * remove sidebar group descriptions (#52453) * Patterns: alternative grid layout to improve keyboard accessibility (#52357) * add sync tooltip (#52458) * Patterns: Update section heading levels (#52273) * Ensure that the unsaved title is not persisted when reopening the modal (#52473) * Iframe: avoid asset parsing & fix script localisation (#52405) * Iframe: avoid asset parsing & fix script localisation * Add e2e test for script localisation * Update descriptions (#52468) * Footnotes: show in inserter and placehold (#52445) * Footnotes: show in inserter and placehold * Fix placeholder block membrane; fix copy; add icon, label --------- Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> * Fix: Focus loss on navigation link label editing on Firefox. (#52428) * Update tooltip (#52465) * Refactor, document, and fix image block deprecations (#52081) * Refactor, document, and fix image block deprecations * Fix v5 attributes & supports * Fix v1 & v2 deprecation tests * Rename deprecated test descriptions * Respect custom aspect ratio (#52286) * add image width and height via css inline style, update width and height attrs to be string * keep width and height as attributes too, keep the attributes as numbers * updates image fixtures * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content (#52241) * RichText/Footnotes: make getRichTextValues work with InnerBlocks.Content --------- Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> * Footnotes: save numbering through the entity provider (#52423) * Footnotes: save numbering through the entity provider * Add sup so no styling is needed at all * Migrate old format * Restore old styles, fix nested attribute queries * Fix anchor selection * Migrate markup in entity provider instead * Fix tests * Fix typo * Fix comment --------- Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> * Revert "Post editor: Require confirmation before removing Footnotes (#52277)" (#52486) This reverts commit e6426ea. * List block: Fix selected type option (#52472) * Library - make pattern title clickable (#51898) * Use button inside title * Remove href * Preserve roving tab index * Fix link colors to match trunk $gray-600 * Remove redundant var * Amend colors as per review * remove old files again --------- Co-authored-by: scruffian <ben@scruffian.com> * remove status icon (#52457) * Rename block theme activation nonce variable. (#52398) --------- Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Glen Davies <glen.davies@automattic.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Juan Aldasoro <juanfraa@gmail.com> Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> Co-authored-by: Jorge Costa <jorge.costa@developer.pt> Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: Héctor <27339341+priethor@users.noreply.github.com> Co-authored-by: Petter Walbø Johnsgård <petter@dekode.no> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: scruffian <ben@scruffian.com> Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52419
What?
This PR will fix the areas where HTML entities are not decoded on the Pattarns page and Template (Parts) page of the Site editor.
Why?
The
titleproperty of the entity record hasraworrenderedproperty; the HTML entity of the value of therenderedproperty is not decoded, so I think we need to add an explicit decoding process.How?
I have checked various actions, including the renaming modal reported in #52419, and added processing where decoding is needed.
Testing Instructions
I have fixed the problem in a total of 9 places. In this PR, confirm that the HTML entities in the following locations are decoded correctly. Here is an example of the test text.
Template rename modal
Template part rename modal
Template part delete modal
Snackbar when duplicating a template part
Title and aria-label on Patterns page
Button description on Patterns page
Snack bar when template customization is cleared
Snack bar when template-parts customization is cleared
To test this, activate EmptyTheme and modify theme.json as follows
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" } }, "customTemplates": [ { "name": "custom", "postTypes": [ "page" ], "title": "John & Mike's custom template" } ], "templateParts": [ { "area": "uncategorized", "name": "custom", "title": "John & Mike's custom template parts" } ] }Then make changes to the template (parts).