-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library Refactor #57688
Font Library Refactor #57688
Commits on Jan 22, 2024
-
Font Library: add wp_font_face post type and scaffold font face REST …
…API controller (#57656)
Configuration menu - View commit details
-
Copy full SHA for 5dbb7fc - Browse repository at this point
Copy the full SHA 5dbb7fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e89854a - Browse repository at this point
Copy the full SHA e89854aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 998f084 - Browse repository at this point
Copy the full SHA 998f084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b5717 - Browse repository at this point
Copy the full SHA 90b5717View commit details -
Configuration menu - View commit details
-
Copy full SHA for efffcc8 - Browse repository at this point
Copy the full SHA efffcc8View commit details -
Font Library: delete child font faces and font assets when deleting p…
…arent (#57867) Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c263a04 - Browse repository at this point
Copy the full SHA c263a04View commit details -
Font Library: refactor client side install functions to work with rev…
…ised API (#57844) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com>
Configuration menu - View commit details
-
Copy full SHA for e8ca12c - Browse repository at this point
Copy the full SHA e8ca12cView commit details -
Cleanup/font library view error handling (#57926)
* Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) * moved response processing into the resolver for fetchGetFontFamilyBySlug * Moved response processing for font family installation to the resolver * Refactored font face installation process to handle errors more cleanly * Cleanup error handling for font library view * Add i18n function to error messages * Add TODO comment for uninstall notice --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
Configuration menu - View commit details
-
Copy full SHA for 13b5640 - Browse repository at this point
Copy the full SHA 13b5640View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e37968 - Browse repository at this point
Copy the full SHA 3e37968View commit details -
Font Library: Update uninstall/delete on client side (#57932)
* Fix delete endpoint * Update fetchUninstallFontFamily to match new format * Update uninstallFont * Add uninstall notice back in * Tidy up comments * Re-word uninstall notices * Add spacing to error message * Refactored how font family values were processed so they would retain their id, which is now used to delete a font family without fetching data via slug * Rename uninstallFont to uninstallFontFamily * Throw uninstall errors rather than returning them --------- Co-authored-by: Jason Crist <jcrist@pbking.com>
Configuration menu - View commit details
-
Copy full SHA for d1f8dcf - Browse repository at this point
Copy the full SHA d1f8dcfView commit details -
Update packages/edit-site/src/components/global-styles/font-library-m…
…odal/local-fonts.js Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3e5e987 - Browse repository at this point
Copy the full SHA 3e5e987View commit details -
Font Library: address JS feedback in #57688 (#57961)
* Wrap error messages in sprintf * Use await rather than then * Add variables for API URLs * Update packages/edit-site/src/components/global-styles/font-library-modal/resolvers.js Co-authored-by: Jeff Ong <jonger4@gmail.com> --------- Co-authored-by: Jeff Ong <jonger4@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dd885b5 - Browse repository at this point
Copy the full SHA dd885b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ed7a3b - Browse repository at this point
Copy the full SHA 2ed7a3bView commit details -
Font Library: font collection refactor to use the new schema (#57884)
* google fonts collection data provisional url * rename controller methods * fix get_items parameters * fix endpoint return * rafactor font collection class * fix tests for the refactored class * refactor font collections rest controller * update font collection tests * update the frontend to use the new endpoint data schema * format php * adding linter line ignore rul * replacing throwing an exception by calling doing_it_wrong * add translation marks Co-authored-by: Jeff Ong <jonger4@gmail.com> * user ternary operator * correct translation formatting and comments * renaming function * renaming tests * improve url matching Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * return error without rest_ensure_response * fix contradictory if condition --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c0e9949 - Browse repository at this point
Copy the full SHA c0e9949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51345f0 - Browse repository at this point
Copy the full SHA 51345f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d45d540 - Browse repository at this point
Copy the full SHA d45d540View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1320d20 - Browse repository at this point
Copy the full SHA 1320d20View commit details
Commits on Jan 23, 2024
-
Font Library: Fix font collection filtering (#58091)
* update function to expect the new schema * update component to expect the new categories schema * update unit tests
Configuration menu - View commit details
-
Copy full SHA for 4dce262 - Browse repository at this point
Copy the full SHA 4dce262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da3f45 - Browse repository at this point
Copy the full SHA 3da3f45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2743793 - Browse repository at this point
Copy the full SHA 2743793View commit details -
Font Library: fix to activate and display the right activation state …
…of system fonts (fonts with no font faces) (#58093) * fix to activate and display the right activation state of system fonts (fonts with no font faces) * if the font family has an empty array of fontfaces it should be unactivated as a family
Configuration menu - View commit details
-
Copy full SHA for b98c028 - Browse repository at this point
Copy the full SHA b98c028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 921ec13 - Browse repository at this point
Copy the full SHA 921ec13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14b9e53 - Browse repository at this point
Copy the full SHA 14b9e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for f460811 - Browse repository at this point
Copy the full SHA f460811View commit details -
Font library: Fix React key prop warnings (#57939)
* Font Library: add wp_font_face post type and scaffold font face REST API controller (#57656) * Font Library: create font faces through the REST API (#57702) * Refactor Font Family Controller (#57785) * Font Family and Font Face REST API endpoints: better data handling and errors (#57843) * Font Families REST API endpoint: ensure unique font family slugs (#57861) * Font Library: delete child font faces and font assets when deleting parent (#57867) Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> * Font Library: refactor client side install functions to work with revised API (#57844) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> * Cleanup/font library view error handling (#57926) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) * moved response processing into the resolver for fetchGetFontFamilyBySlug * Moved response processing for font family installation to the resolver * Refactored font face installation process to handle errors more cleanly * Cleanup error handling for font library view * Add i18n function to error messages * Add TODO comment for uninstall notice --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Fix unique key prop warning when opening modal * Add key props to FontsGrid children * Font Faces endpoint: prevent creating font faces with duplicate settings (#57903) * Font Library: Update uninstall/delete on client side (#57932) * Fix delete endpoint * Update fetchUninstallFontFamily to match new format * Update uninstallFont * Add uninstall notice back in * Tidy up comments * Re-word uninstall notices * Add spacing to error message * Refactored how font family values were processed so they would retain their id, which is now used to delete a font family without fetching data via slug * Rename uninstallFont to uninstallFontFamily * Throw uninstall errors rather than returning them --------- Co-authored-by: Jason Crist <jcrist@pbking.com> * Add slug/id back to FontCollection * Change tabsFromCollections inline with Font Collections PR * Use child.key for key prop in FontsGrid * Update packages/edit-site/src/components/global-styles/font-library-modal/local-fonts.js Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> * Font Library: address JS feedback in #57688 (#57961) * Wrap error messages in sprintf * Use await rather than then * Add variables for API URLs * Update packages/edit-site/src/components/global-styles/font-library-modal/resolvers.js Co-authored-by: Jeff Ong <jonger4@gmail.com> --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> * Font Library REST API endpoints: address initial feedback from feature branch (#57946) * Font Library: font collection refactor to use the new schema (#57884) * google fonts collection data provisional url * rename controller methods * fix get_items parameters * fix endpoint return * rafactor font collection class * fix tests for the refactored class * refactor font collections rest controller * update font collection tests * update the frontend to use the new endpoint data schema * format php * adding linter line ignore rul * replacing throwing an exception by calling doing_it_wrong * add translation marks Co-authored-by: Jeff Ong <jonger4@gmail.com> * user ternary operator * correct translation formatting and comments * renaming function * renaming tests * improve url matching Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * return error without rest_ensure_response * fix contradictory if condition --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * Remove old WP_REST_Autosave_Fonts_Controller class --------- Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> Co-authored-by: Grant Kinney <hi@grant.mk> Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 51e4bed - Browse repository at this point
Copy the full SHA 51e4bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23ce4e9 - Browse repository at this point
Copy the full SHA 23ce4e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb30f83 - Browse repository at this point
Copy the full SHA eb30f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for dde2059 - Browse repository at this point
Copy the full SHA dde2059View commit details