Release 0.8.6 #1294
Merged
Release 0.8.6 #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem**
the logic behind `countDuplicates` is invalid because it's doing this:
(incorrect)
```
if(duplicates + e11 == e21)
duplicates = 1;
else
duplicates = 0;
```
Instead of this:
(correct)
```
if(e11 == e21)
duplicates = duplicates + 1;
else
duplicates = duplicates;
```
**Solution**
I'm using an auxiliary variable to fix this
**Alternative solution**
We can also fix it with an array and a loop. But I went for the auxiliary variable for no particular reason.
```
def countDuplicates(field e11, field e12, field e21, field e22) -> u32 {
u32[6] mut duplicates = [0,0,0,0,0,0];
duplicates[0] = e11 == e12 ? 1 : 0;
duplicates[1] = e11 == e21 ? 1 : 0;
duplicates[2] = e11 == e22 ? 1 : 0;
duplicates[3] = e12 == e21 ? 1 : 0;
duplicates[4] = e12 == e22 ? 1 : 0;
duplicates[5] = e21 == e22 ? 1 : 0;
u32 mut count = 0;
for u32 i in 0..5 {
count = count + duplicates[i];
}
return count;
}
```
And btw, I also added an assert to make sure we check for this validation. I've tested this on the playground and on chain on goerli and with this changes it works correctly.
…struction instead of canonical
Optimize assembly solvers
Merge back 0.8.5
Sudoku example fix
Optimize backend integrations
add sourcemaps
make zokrates build on stable rust
dark64
previously approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.