Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add throttling to OTF2TTF to avoid hangs on Windows with large CPU (#1420) #1421

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Add throttling to OTF2TTF to avoid hangs on Windows with large CPU (#1420) #1421

merged 2 commits into from
Oct 27, 2021

Conversation

be5invis
Copy link
Contributor

@be5invis be5invis commented Oct 22, 2021 •
edited
Loading

Description

This change adds throttling to otf2ttf to avoid hanging on Windows if the system has a CPU with 64 or more logical processors. Fixes #1420.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@be5invis be5invis changed the title Add throttle to OTF2TTF to avoid hangs on Windows with large CPU (#1420) Add throttling to OTF2TTF to avoid hangs on Windows with large CPU (#1420) Oct 22, 2021
josh-hadley
josh-hadley requested changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@be5invis can you please address the flake8 issue (see here)

@be5invis
Copy link
Contributor Author

@josh-hadley Now all validations pass.

josh-hadley
josh-hadley approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this patch.

@josh-hadley josh-hadley merged commit b4ff545 into adobe-type-tools:develop Oct 27, 2021
@be5invis be5invis deleted the be/bugfix-1420 branch October 27, 2021 18:39
This was referenced Jul 3, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-hadley josh-hadley josh-hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

otf2ttf hangs on Windows if the system has 64 or more threads
2 participants
@be5invis @josh-hadley