Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure poolCapacity is at least 1 #1530

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Ensure poolCapacity is at least 1 #1530

merged 1 commit into from
Jul 4, 2022

Conversation

Heptazhou
Copy link
Contributor

Description

#1421 introduced only an upper-limit but not a lower one. It causes errors in some cases.

This pr will fix the problem.

Checklist:

  • I have followed the Contribution Guidelines
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Heptazhou Heptazhou mentioned this pull request Jul 4, 2022
Closed
6 tasks
miguelsousa
miguelsousa approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miguelsousa miguelsousa merged commit 0921ab4 into adobe-type-tools:develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heptazhou @miguelsousa