Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force maxPoolCapacity to be at least 1 #1529

Closed
wants to merge 1 commit into from

Conversation

Heptazhou
Copy link
Contributor

Description

#1421 introduced only an upper-limit but not a lower one. It causes errors in some cases.

This pr shall fix the problem.

Checklist:

  • I have followed the Contribution Guidelines
  • I have added test code and data to prove that my code functions correctly
  • I have verified that new and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@miguelsousa
Copy link
Member

@Heptazhou CI is failing because

./python/afdko/otf2ttf.py:155:80: E501 line too long (89 > 79 characters)
    # Set the pool capacity to be the minimum of file quantity and CPU count, at least 1.
                                                                               ^

@Heptazhou
Copy link
Contributor Author

@miguelsousa I think it's good to go now.

@miguelsousa
Copy link
Member

@Heptazhou the changes look good, but the CI didn't run for some reason. Can you try flatten both commits into just one and force-push?

@Heptazhou
Copy link
Contributor Author

Sure!

@miguelsousa
Copy link
Member

@Heptazhou The CI is still stuck, and I don't know why. Do you mind opening a new PR? Thanks.

@Heptazhou
Copy link
Contributor Author

No problem.

@Heptazhou Heptazhou closed this Jul 4, 2022
@Heptazhou
Copy link
Contributor Author

@miguelsousa see #1530 :D

@Heptazhou Heptazhou deleted the patch-1 branch July 24, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants