Main #2012
Merged
Main #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MWPW-143673: Load Milo fragment modals from co links #1972 MWPW-142894: fragments can lead to invalid html #1937 High Priority Caas-Marquee: Fixes integration with martech.js issues #2003 MWPW-143591 Fix Contextual Search Duplicates #1990 Zero Impact MWPW-143708 and MWPW-143712 add kodiak auto-ticketing #2002 --------- Co-authored-by: J. Casalino <casalino@adobe.com> Co-authored-by: Megan Thomas <methomas@adobe.com> Co-authored-by: ilyas Stéphane Türkben <tuerkben@adobe.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: cmiqueo <64917520+cmiqueo@users.noreply.github.com>
* Update martech.main.standard.min.js (#2008) --------- Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com>
Blainegunn
requested review from
a team,
overmyheadandbody,
mokimo,
narcis-radu,
meganthecoder,
JasonHowellSlavin,
Brandon32 and
rgclayton
as code owners
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+1
to
2
|
|
||
| /* eslint-disable no-shadow, consistent-return, max-len, quote-props, prefer-const */ |
There was a problem hiding this comment.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
Too many blank lines at the beginning of file. Max of 0 allowed.
Suggested change
| /* eslint-disable no-shadow, consistent-return, max-len, quote-props, prefer-const */ | |
| /* eslint-disable no-shadow, consistent-return, max-len, quote-props, prefer-const */ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2012 +/- ##
==========================================
+ Coverage 95.57% 96.32% +0.75%
==========================================
Files 148 165 +17
Lines 38148 42274 +4126
==========================================
+ Hits 36460 40721 +4261
+ Misses 1688 1553 -135 ☔ View full report in Codecov by Sentry. |
yesil
approved these changes
Mar 15, 2024
vhargrave
reviewed
Mar 18, 2024
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
I just saw we had the same thought to get things fixed. - #2025
we probably shouldn't have this empty line no?
Maybe we close this PR and just merge mine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-NUMBER
Test URLs: