MWPW-165774 [Mobile-GNAV] page is not scrollable in live page #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmrj
requested review from
salonijain3,
bandana147,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
sharmrj
changed the title
salonijain3
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3495 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 256 256
Lines 60101 60102 +1
=======================================
+ Hits 57989 57990 +1
Misses 2112 2112 ☔ View full report in Codecov by Sentry. |
mokimo
approved these changes
Jan 16, 2025
bandana147
approved these changes
Jan 16, 2025
| @@ -337,7 +337,8 @@ export function trigger({ element, event, type } = {}) { | |||
| closeAllDropdowns({ type }); | |||
| if (isOpen) return false; | |||
| element.setAttribute('aria-expanded', 'true'); | |||
| if (!isDesktop.matches && type === 'dropdown') disableMobileScroll(); | |||
| if (!isDesktop.matches && type === 'dropdown' | |||
| && document.querySelector('header').classList.contains('new-nav')) disableMobileScroll(); | |||
There was a problem hiding this comment.
Couldn't this be trimmed to document.querySelector('header.new-nav')?
|
Validation done on the pr in the below urls Recording.2025-01-16.145212.mp4 |
spadmasa
added
verified
mokimo
pushed a commit
that referenced
this pull request
Jan 16, 2025
MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
milo-pr-merge bot
added a commit
that referenced
this pull request
Feb 4, 2025
…3503) * Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357) Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)" This reverts commit 81a5770. * [Release] Stage to Main (#3497) MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495) * check for new nav when disabling ios scroll * shortened the check from the previous commit Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> * MWPW-155425: ability to add multiple event states * MWPW-155425: adjusting the order of the filter messages * MWPW-155425: unit tests --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-165774
Test URLs: