Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3497

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[Release] Stage to Main #3497

merged 1 commit into from
Jan 16, 2025

Conversation

* check for new nav when disabling ios scroll

* shortened the check from the previous commit
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jan 16, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (b1351a6) to head (3076a7a).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3497   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         256      256           
  Lines       60101    60102    +1     
=======================================
+ Hits        57989    57990    +1     
  Misses       2112     2112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa added the verified PR has been E2E tested by a reviewer label Jan 16, 2025
@spadmasa spadmasa added the Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs label Jan 16, 2025
@spadmasa spadmasa added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jan 16, 2025
@spadmasa spadmasa added the high-impact Any PR that may affect consumers label Jan 16, 2025
@mokimo mokimo merged commit c56840d into main Jan 16, 2025
39 checks passed
milo-pr-merge bot added a commit that referenced this pull request Feb 4, 2025
…3503)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (#3259)"

This reverts commit 81a5770.

* [Release] Stage to Main (#3497)

MWPW-165774 [Mobile-GNAV] page is not scrollable in live page (#3495)

* check for new nav when disabling ios scroll

* shortened the check from the previous commit

Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>

* MWPW-155425: ability to add multiple event states

* MWPW-155425: adjusting the order of the filter messages

* MWPW-155425: unit tests

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Raghav Sharma <118168183+sharmrj@users.noreply.github.com>
Co-authored-by: Sheridan Sunier <sunier@sheridans-mbp.corp.adobe.com>
Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? high-impact Any PR that may affect consumers Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants