Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164967 [NALA] test for Target enablement #3504

Open
wants to merge 5 commits into
base: stage
Choose a base branch
from
Open

Conversation

jpratt2
Copy link
Contributor

@jpratt2 jpratt2 commented Jan 16, 2025

This test checks for the ability to enable Target via page metadata and via URL parameter. (The ability to use the global metadata spreadsheet was purposely omitted due to it being absent in the milo repository.)

Resolves: MWPW-164967

Test URLs:

Nala test pages:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on2?target=on
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on

The marquee headline should say "Target is running" in both URLs. The first URL uses parameterization, the second uses page metadata.

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 16, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6eb0401) to head (69c474b).
Report is 20 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3504   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         258      258           
  Lines       60150    60150           
=======================================
  Hits        58029    58029           
  Misses       2121     2121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@jpratt2
Copy link
Contributor Author

jpratt2 commented Jan 17, 2025

This is being reviewed by Santosh in case a headed browser is required.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PR should not be merged yet Stale zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants