-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-164967 [NALA] test for Target enablement #3504
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3504 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 258 258
Lines 60150 60150
=======================================
Hits 58029 58029
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
This is being reviewed by Santosh in case a headed browser is required. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This test checks for the ability to enable Target via page metadata and via URL parameter. (The ability to use the global metadata spreadsheet was purposely omitted due to it being absent in the milo repository.)
Resolves: MWPW-164967
Test URLs:
Nala test pages:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on2?target=on
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on
The marquee headline should say "Target is running" in both URLs. The first URL uses parameterization, the second uses page metadata.