MWPW-164967 [NALA] test for Target enablement #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 16, 2025 13:49
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3509 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 258 258
Lines 60150 60150
=======================================
Hits 58029 58029
Misses 2121 2121 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks for the ability to enable Target via page metadata and via URL parameter. (The ability to use the global metadata spreadsheet was purposely omitted due to it being absent in the milo repository.)
Resolves: MWPW-164967
Nala test pages:
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on2?target=on
https://main--milo--adobecom.hlx.page/drafts/nala/features/personalization/target-on/target-on
The marquee headline should say "Target is running" if working correctly for both of the URLs above.
Test URLs: