Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scan iter command issued to different replicas #1

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

fix scan iter command issued to different replicas #1

wants to merge 49 commits into from

Conversation

agnesnatasya
Copy link
Owner

@agnesnatasya agnesnatasya commented Apr 26, 2024 •
edited
Loading

Pull Request check-list

  • Do tests and lints pass with this change?
    • lint passes
    • test passes on Ubuntu 22.04, python3.11.2
Starting Redis tests
= 2352 passed, 1235 skipped, 849 deselected, 29 xpassed, 347 warnings in 163.65s (0:02:43) =
Waiting for 6 cluster nodes to become available
All nodes are available!
= 1571 passed, 1494 skipped, 1396 deselected, 4 xpassed, 244 warnings in 728.56s (0:12:08) =
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested? added tests coverage
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? bugfix only
    • I added some docstring to redis.asyncio.sentinel module. I wanted to check if the rST syntax is correct, but this module is not included in the builddir's index, so I think it's no-op.
  • Is there an example added to the examples folder (if applicable)? bugfix only
  • Was the change added to CHANGES file? bugfix only

fix scan iter command issued to different replicas

Fixes redis#3197

@agnesnatasya agnesnatasya marked this pull request as draft April 26, 2024 16:12
@agnesnatasya agnesnatasya marked this pull request as ready for review April 26, 2024 16:14
@agnesnatasya agnesnatasya mentioned this pull request Apr 30, 2024
Open
9 tasks
kurtmckee and others added 5 commits July 17, 2024 11:38
@kurtmckee
Close Unix sockets if the connection attempt fails (redis#3315)
b2179f6 
Make sure Unix sockets get closed if the connection fails.

Fixes redis#3314
@kurtmckee
Suppress Graph deprecation warning in test suite (redis#3316)
b206a0f 
Move pytest warning control to `pytest.ini`.

Ignore `Graph` `DeprecationWarning` in the test suite

One extra test is added to verify the warning is actually thrown.
@kurtmckee
Close SSL sockets when connections/validations fail (redis#3318)
9607608 
Handle more cases of failure when initializing SSL sockets, and make
sure no socket is left unclosed in case of errors.

Fixes redis#3317
@gerzse
Upgrade Flake8 (redis#3323)
7e2b4fb 
Use the latest available Flake8. Fix some linter errors that surfaced.

Take the opportunity to fix typing hints and remove code duplication
around CommandsProtocol.
@kurtmckee
Resolve some docs warnings (redis#3322)
2ffcac3 
Get rid of some warning related to documentation.
@agnesnatasya
fix connect_to_address
d7f8e90
@agnesnatasya
cleanup in sync client
d1c25b9
@agnesnatasya
rename kwargs to no underscore for consistency
b8aeb71
@agnesnatasya
add cleanup tests for pipeline
ca7d0ff
@agnesnatasya
remove test for pipeline
b21f1ea
@agnesnatasya
lints
24b3072
@agnesnatasya
reformat
1d29914
@agnesnatasya
def cleanup in base class
a4e20ac
@agnesnatasya
fix some tests
12e6495
@agnesnatasya
rename iter_req_id properly
a7ffda8
@agnesnatasya
fix tests
8a1bc06
@agnesnatasya
set fix address as a property of SentinelManagedConnection
f504741
@agnesnatasya
lint
c75db8d
@agnesnatasya
make mock class have same behavior as actual class
0f5e079
@agnesnatasya
define _connect_to_sentinel in async server
ef0d969
@agnesnatasya
mock can_read_destructive for parser
bb69c85
@agnesnatasya
skip test sentinel managed connection if hirediswq
a4601a7
@agnesnatasya
undo ensure_connection deduplication in BlockingConnectionPool
88501a0
@agnesnatasya
import HIREDIS
c75262b
@agnesnatasya
polymorphism for reset available connections instead
cdbe957
@agnesnatasya
merge
ac20752
@agnesnatasya
lint
9405695
@agnesnatasya
fix inline comments + rename
a1ece92
@agnesnatasya
lint
eede649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scan_iter family commands gives inconsistent result when using Sentinel connection pool
3 participants
@agnesnatasya @kurtmckee @gerzse