Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange rates source description needs update #20340

Closed
Ezziddeen-Abdulwahhab opened this issue Dec 10, 2022 · 2 comments
Closed

Exchange rates source description needs update #20340

Ezziddeen-Abdulwahhab opened this issue Dec 10, 2022 · 2 comments
Assignees
Labels
area/documentation Improvements or additions to documentation autoteam community team/documentation type/bug Something isn't working

Comments

@Ezziddeen-Abdulwahhab
Copy link

Environment

  • Airbyte version: v0.40.25
  • OS Version / Instance: Centos 7 VM
  • Deployment: NA
  • Source Connector and version: Exchange rates 1.2.7 (Sorry if this version is inaccurate, I'm still new here)
  • Step where error happened: Setup new connection

Current Behavior

I wanted to setup a data source using the "Exchange rates API". I followed the steps in the connector's description (right pane in the image)
image
I generated a token from "https://exchangeratesapi.io/" and I tried to continue setting up the data source but I got the following error:
The connection tests failed. 'Invalid authentication credentials'

I investigated to see what the problem was and it turns out "https://exchangeratesapi.io/" is no longer in use. It was updated to another data source("https://apilayer.com/marketplace/exchangerates_data-api") in the following PR #15884 , but the description was not updated. I generated a new token, this time from "https://apilayer.com/marketplace/exchangerates_data-api" and it worked.
The following links also need to be updated due to the data source change from exchange-api to apilayer:

There could be other links/areas that need update that I'm unware of.

Expected Behavior

The description should be changed to match the new data source which is "apilayer.com".

Logs

NA

Steps to Reproduce

  1. Go to setup new connection
  2. Use "Exchange rates" API as a source
  3. Follow the source setup guide on the right pane
  4. Use a token generated from "https://exchangeratesapi.io/"

Are you willing to submit a PR?

I wanted to submit a PR for this and make it my first contribution(I'm new here, I'm trying to get into open-source), but unfortunately, I couldn't get the following guide to work in time
https://docs.airbyte.com/contributing-to-airbyte/developing-locally/
Now something else came up and it'll be some time before I come back to this. Wish you the best.

@Ezziddeen-Abdulwahhab Ezziddeen-Abdulwahhab added needs-triage type/bug Something isn't working labels Dec 10, 2022
@sh4sh sh4sh added area/documentation Improvements or additions to documentation and removed needs-triage team/tse Technical Support Engineers autoteam labels Jan 19, 2023
@sh4sh sh4sh self-assigned this Jan 19, 2023
@juweins
Copy link
Contributor

juweins commented Jan 26, 2023

@Ezziddeen-Abdulwahhab Thanks for pointing out this issue! How are you doing so far? Are you planning fixing this issue soon?

@nataliekwong
Copy link
Contributor

Thanks for creating this issue! It has now been addressed in #31566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation autoteam community team/documentation type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants