-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Exchange Rates - Refactor for API Layer #15884
Source Exchange Rates - Refactor for API Layer #15884
Conversation
/test connector=source-exchange-rates |
/test connector=connectors/source-exchange-rates
Build FailedTest summary info:
|
Hi @natalyjazzviolin , the build has failed. What are the next steps? |
@jonathanneo I'm debugging it, should have an update for you soon :) |
/test connector=connectors/source-exchange-rates
Build FailedTest summary info:
|
Hi @natalyjazzviolin , any updates? |
@jonathanneo the integration tests are breaking on our end since we haven't updated our credentials with a new api key from APILayer. Just made an issue requesting for one to be made so please stay tuned. Appreciate the contribution, hope to get this merged as soon as it's unblocked. Let me know if you have questions :) |
…onalProperties: true in reference to #14196.
@jonathanneo our integration tests are also failing due to changes in Hopefully we can get this tested and merged in soon, thank you so much for the fix! |
Awesome! Thanks both for testing the change :) |
Hi @sajarin just following up :) |
/test connector=source-exchange-rates
Build PassedTest summary info:
|
…onathanneo/airbyte into source-exchange-rates-apilayer
/publish connector=source-exchange-rates
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-exchange-rates
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* refactor for api layer * changelog * Reverts variable name for backwards compatability tests & sets additionalProperties: true in reference to airbytehq#14196. * fix: bump dockerfile * fix: update changelog version to match Dockerfile * fix: actually update changelog version to match Dockerfile * auto-bump connector version [ci skip] Co-authored-by: Nataly Merezhuk <65251165+natalyjazzviolin@users.noreply.github.com> Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: nataly <nataly@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* refactor for api layer * changelog * Reverts variable name for backwards compatability tests & sets additionalProperties: true in reference to airbytehq#14196. * fix: bump dockerfile * fix: update changelog version to match Dockerfile * fix: actually update changelog version to match Dockerfile * auto-bump connector version [ci skip] Co-authored-by: Nataly Merezhuk <65251165+natalyjazzviolin@users.noreply.github.com> Co-authored-by: Sajarin <sajarindider@gmail.com> Co-authored-by: nataly <nataly@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
The Rates API used for the Airbyte demo for Python CDK (HTTP) connectors has been deprecated.
The Rates API is now being served by API Layer. Here is the new API documentation.
This PR resolves the following issues:
How
url_base
to the new url:https://api.apilayer.com/exchangerates_data/
spec.yaml
to useapi_key
instead ofaccess_key
so that it aligns with the new API terminologyrequest_headers()
to pass a header withapikey
to the endpointRecommended reading order
source_exchange_rates/spec.yaml
source_exchange_rates/source.py
🚨 User Impact 🚨
api_key
instead ofaccess_key
so that it aligns with the new API terminology.Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
No unit tests were created by the original airbyte author.
Integration
Running integration tests locally from the root of the repo using the command
./gradlew :airbyte-integrations:connectors:source-exchange-rates:integrationTest
results in the following error:Acceptance
Running
docker run --rm -v $(pwd)/integration_tests:/integration_tests airbyte/source-exchange-rates:dev read --config /integration_tests/config.json --catalog /integration_tests/configured_catalog.json
resulted in a successful sync: