Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exchange-rates.md #31566

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

mr-W3dnesday
Copy link
Contributor

Update links in documentation to API layer docs

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.
Links in exchange rates documentation point to legacy API endpoint documentation, this has been migrated to API layer in PR 15884. I've just updated the documentation to include the new API docs

How

Describe the solution
Edited some links in markdown files

Recommended reading order

  1. exchange-rates.md

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?
No user impact, except improved ease when setting up connection

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
No breaking changes, unsure if even a minor version bump is necessary for just a documentation change

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 3:19pm

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

/approve-and-merge reason="only doc changes"

@octavia-approvington
Copy link
Contributor

A crack team of mammals has made a decision.
imagine a seal of approval

@octavia-approvington octavia-approvington merged commit 8ac1ee5 into airbytehq:master Oct 18, 2023
11 checks passed
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation community
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants