Improve E2E testing around the Connection Form #17577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teallarson
reviewed
Oct 6, 2022
airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts
Outdated
Show resolved
Hide resolved
teallarson
reviewed
Oct 6, 2022
| deleteDestination(destName); | ||
| }); | ||
|
|
||
| it("Saving a connection's schedule type only changes expected values", () => { |
There was a problem hiding this comment.
this was added in response to a specific OC bug 👍
lmossman
approved these changes
Oct 6, 2022
| openSourceDestinationFromGrid(sourceName); | ||
| openSourceDestinationFromGrid(`${sourceName} <> ${destName}`); | ||
|
|
||
| let loadedConnection: any = null; // Should be a WebBackendConnectionRead |
There was a problem hiding this comment.
Just curious, do we have any plans to pull in types from the airbyte-webapp module in the future?
There was a problem hiding this comment.
I'm not sure what it would entail to do so. It might be trivial but no, I don't think we have a plan to do so. I wouldn't mind though.
airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts
Outdated
Show resolved
Hide resolved
krishnaglick
commented
Oct 7, 2022
airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts
Outdated
Show resolved
Hide resolved
teallarson
approved these changes
Oct 7, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 10, 2022
…vation * master: (22 commits) Update full-refresh-append.md (#17784) Update full-refresh-overwrite.md (#17783) Update incremental-append.md (#17785) Update incremental-deduped-history.md (#17786) Update cdc.md (#17787) 🪟 🔧 Ignore classnames during jest snapshot comparison (#17773) feat: replace openjdk with amazoncorretto:17.0.4 on connectors for seсurity compliance (#17511) Start testing buildpulse. (#17712) Add missing types to the registry (#17763) jobs db descriptions (#16543) config db data catalog (#16427) Update lowcode docs (#17752) db migrations to support new webhook operations (#17671) Bump Airbyte version from 0.40.13 to 0.40.14 (#17762) September Release Notes (#17754) Revert "Use java-datadog-tracer-base image (#17625)" (#17759) Add connection migrations for schema changes (#17651) Connection Form Refactor - Part Two (#16748) Improve E2E testing around the Connection Form (#17577) Bump strict encrypt version (#17747) ...
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Added an e2e test: creates a connection, then edits the schedule type * Schedule types successfully tested! * Removing .only * Prefix testing * Analytics calls fire as expected * Strict connection save check for schedule type * better check * Fixing failing tests * Lake CR * Update airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts * Can't test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve E2E testing around the Connection Form
How
Add E2E tests around the Connection Form