Add connection migrations for schema changes #17651
Conversation
alovew
requested review from
gosusnp,
benmoriceau,
jdpgrailsdev and
colesnodgrass
| ctx.alterTable("connection") | ||
| .addColumnIfNotExists(DSL.field( | ||
| "notify_schema_changes", | ||
| SQLDataType.BOOLEAN.nullable(false).defaultValue(true))) |
There was a problem hiding this comment.
I know we want to have it on by default, just to make sure do we want to turn it on automatically for all existing connections?
There was a problem hiding this comment.
My understanding is yes, but I can double check with Andy.
| private static void addBreakingChange(final DSLContext ctx) { | ||
| ctx.alterTable("connection") | ||
| .addColumnIfNotExists(DSL.field( | ||
| "breaking_change", |
There was a problem hiding this comment.
I think this is about notifications, can we be more explicit and add it to the name?
There was a problem hiding this comment.
this is not about notifications - this is a boolean about whether this connection has breaking changes
| private static void addNonBreakingChangePreference(final DSLContext ctx) { | ||
| ctx.alterTable("connection") | ||
| .addColumnIfNotExists(DSL.field( | ||
| "non_breaking_change_preference", |
There was a problem hiding this comment.
I think this is about notifications, can we be more explicit and add it to the name?
There was a problem hiding this comment.
+1 for @gosusnp's suggestion. If this is for notification, we should probably have that in the column name.
There was a problem hiding this comment.
this is also not about notifications - this is about the user's preference for how we handle non-breaking changes: either disable the connection or ignore
| @@ -138,7 +138,7 @@ void testBootloaderAppBlankDb() throws Exception { | |||
| val configsMigrator = new ConfigsDatabaseMigrator(configDatabase, configsFlyway); | |||
| // this line should change with every new migration | |||
| // to show that you meant to make a new migration to the prod database | |||
| assertEquals("0.40.11.001", configsMigrator.getLatestMigration().getVersion().getVersion()); | |||
| assertEquals("0.40.11.002", configsMigrator.getLatestMigration().getVersion().getVersion()); | |||
There was a problem hiding this comment.
I don't think it matters but it should be 0.40.13.000
There was a problem hiding this comment.
I think there was an upgrade since Wednesday when I wrote this
…vation * master: (22 commits) Update full-refresh-append.md (#17784) Update full-refresh-overwrite.md (#17783) Update incremental-append.md (#17785) Update incremental-deduped-history.md (#17786) Update cdc.md (#17787) 🪟 🔧 Ignore classnames during jest snapshot comparison (#17773) feat: replace openjdk with amazoncorretto:17.0.4 on connectors for seсurity compliance (#17511) Start testing buildpulse. (#17712) Add missing types to the registry (#17763) jobs db descriptions (#16543) config db data catalog (#16427) Update lowcode docs (#17752) db migrations to support new webhook operations (#17671) Bump Airbyte version from 0.40.13 to 0.40.14 (#17762) September Release Notes (#17754) Revert "Use java-datadog-tracer-base image (#17625)" (#17759) Add connection migrations for schema changes (#17651) Connection Form Refactor - Part Two (#16748) Improve E2E testing around the Connection Form (#17577) Bump strict encrypt version (#17747) ...
Add three new columns to support the auto-detect schema change feature: