Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java-datadog-tracer-base image #17625

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Use java-datadog-tracer-base image #17625

merged 6 commits into from
Oct 6, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

Closes #17259

How

  • Change the base image of the airbyte-workers, airbyte-cron and airbyte-container-orchestrator.

Tests

  • Built all images locally
  • Ran all images without issue via docker-compose locally

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Oct 5, 2022
@jdpgrailsdev
Copy link
Contributor Author

@gosusnp @benmoriceau I realized after I made this PR that we probably still want the JDK_VERSION and JDK_IMAGE build arguments to allow OSS users to use their own base, if they desire. I have restored those back with default values using the DD base image.

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets October 6, 2022 12:37 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets October 6, 2022 14:03 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets October 6, 2022 15:27 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets October 6, 2022 16:03 Inactive
@jdpgrailsdev jdpgrailsdev merged commit c170173 into master Oct 6, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/apm-agent branch October 6, 2022 18:35
benmoriceau added a commit that referenced this pull request Oct 7, 2022
benmoriceau added a commit that referenced this pull request Oct 7, 2022
letiescanciano added a commit that referenced this pull request Oct 10, 2022
…vation

* master: (22 commits)
  Update full-refresh-append.md (#17784)
  Update full-refresh-overwrite.md (#17783)
  Update incremental-append.md (#17785)
  Update incremental-deduped-history.md (#17786)
  Update cdc.md (#17787)
  🪟 🔧 Ignore classnames during jest snapshot comparison (#17773)
  feat: replace openjdk with amazoncorretto:17.0.4 on connectors for seсurity compliance (#17511)
  Start testing buildpulse. (#17712)
  Add missing types to the registry (#17763)
  jobs db descriptions (#16543)
  config db data catalog (#16427)
  Update lowcode docs (#17752)
  db migrations to support new webhook operations (#17671)
  Bump Airbyte version from 0.40.13 to 0.40.14 (#17762)
  September Release Notes (#17754)
  Revert "Use java-datadog-tracer-base image (#17625)" (#17759)
  Add connection migrations for schema changes (#17651)
  Connection Form Refactor - Part Two (#16748)
  Improve E2E testing around the Connection Form (#17577)
  Bump strict encrypt version (#17747)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
* Use java-datadog-tracer-base image

* Restore build args

* Explicity install tar executable
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support APM observability in OSS
3 participants