Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Highlight to show when there is no highlighted value [react-instanctsearch] #1790

Closed
l4u opened this issue Dec 31, 2016 · 1 comment
Closed

Allow Highlight to show when there is no highlighted value [react-instanctsearch] #1790

l4u opened this issue Dec 31, 2016 · 1 comment
Assignees
@bobylito
Labels
Type: Bug

Comments

@l4u
Copy link

l4u commented Dec 31, 2016

Can we add an option that allows no highlighted attribute?

  1. the attribute might not exist.
  2. the highlighted word might be in another attribute.

https://github.com/algolia/instantsearch.js/blob/e561c7b1865e8fa921b2e1e725c983aae7366861/packages/react-instantsearch/src/core/highlight.js#L27
@bobylito
Copy link
Contributor

bobylito commented Jan 2, 2017 •
edited
Loading

If the attribute exists in some records and not in others, then imho it's a bug. We should be able to declare different attributes and not fear the attributes to be unavailable.

@bobylito bobylito self-assigned this Jan 2, 2017
bobylito pushed a commit that referenced this issue Jan 2, 2017
fix(highlight): highlight should work even if the attribute is missing
3909f1e 
Since algolia does not enforce a schema on the records, it is possible
that an highlighted value is only available on some of them. This means
that react-instantsearch should not throw when highlighting an attribute
that is missing from the hit.

fix #1790
@bobylito bobylito mentioned this issue Jan 2, 2017
Merged
bobylito pushed a commit that referenced this issue Jan 2, 2017
fix(highlight): highlight should work even if the attribute is missing
c12f17c 
Since algolia does not enforce a schema on the records, it is possible
that an highlighted value is only available on some of them. This means
that react-instantsearch should not throw when highlighting an attribute
that is missing from the hit.

fix #1790
mthuret pushed a commit that referenced this issue Jan 3, 2017
@bobylito @mthuret
fix(highlight): highlight should work even if the attribute is missing (
5b79b15 
#1791)

Since algolia does not enforce a schema on the records, it is possible
that an highlighted value is only available on some of them. This means
that react-instantsearch should not throw when highlighting an attribute
that is missing from the hit.

fix #1790
vvo pushed a commit that referenced this issue Jan 4, 2017
v2.1.0
a7ad5bc 
<a name="2.1.0"></a>
# [2.1.0](v2.0.1...v2.1.0) (2017-01-04)

### Bug Fixes

* **createInstantSearchManager:** drop outdated response (#1765) ([76c5312](76c5312))
* **highlight:** highlight should work even if the attribute is missing (#1791) ([5b79b15](5b79b15)), closes [#1790](#1790)
* **InfiniteHits:** better classname to loadmore btn (#1789) ([ad2ded3](ad2ded3))
* **starRatings:** click on selected range doesn't unselect it (#1766) ([beacc72](beacc72))
* **website:** broken demo links (#1802) ([0abe2f5](0abe2f5))
* **widgets:** add 300px width for the default SearchBox (#1803) ([bf5d791](bf5d791))

### Features

* **InfiniteHits:** Add class to load more button (#1787) ([416febd](416febd))
* **RefinementList, connectRefinementList:** allow to search for facet values ([e086a81](e086a81))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobylito bobylito

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l4u @bobylito