Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InfiniteHits): better classname to loadmore btn #1789

Merged
merged 1 commit into from
Jan 2, 2017
Merged

fix(InfiniteHits): better classname to loadmore btn #1789

merged 1 commit into from
Jan 2, 2017

Conversation

adlenafane
Copy link

What project are you opening a pull request for?

  • react-instantsearch (use v2 base)

Summary

Used wrongly reset instead of loadMore
@bobylito Sorry about the typo, just fixed it as the previous PR was merged

@algobot
Copy link
Contributor

algobot commented Dec 31, 2016

By analyzing the blame information on this pull request, we identified @bobylito and @vvo to be potential reviewers

bobylito
bobylito approved these changes Jan 2, 2017
View reviewed changes
Copy link
Contributor

@bobylito bobylito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous name was less related, now is a good time to do this change. Unless we find a better one @vvo

@bobylito bobylito merged commit ad2ded3 into algolia:v2 Jan 2, 2017
@vvo
Copy link
Contributor

vvo commented Jan 4, 2017 •
edited
Loading

Seems like it's a good one, thanks tweaking this with care!

vvo pushed a commit that referenced this pull request Jan 4, 2017
v2.1.0
a7ad5bc 
<a name="2.1.0"></a>
# [2.1.0](v2.0.1...v2.1.0) (2017-01-04)

### Bug Fixes

* **createInstantSearchManager:** drop outdated response (#1765) ([76c5312](76c5312))
* **highlight:** highlight should work even if the attribute is missing (#1791) ([5b79b15](5b79b15)), closes [#1790](#1790)
* **InfiniteHits:** better classname to loadmore btn (#1789) ([ad2ded3](ad2ded3))
* **starRatings:** click on selected range doesn't unselect it (#1766) ([beacc72](beacc72))
* **website:** broken demo links (#1802) ([0abe2f5](0abe2f5))
* **widgets:** add 300px width for the default SearchBox (#1803) ([bf5d791](bf5d791))

### Features

* **InfiniteHits:** Add class to load more button (#1787) ([416febd](416febd))
* **RefinementList, connectRefinementList:** allow to search for facet values ([e086a81](e086a81))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobylito bobylito bobylito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adlenafane @algobot @vvo @bobylito