fix(highlight): highlight should work even if the attribute is missing #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @vvo to be a potential reviewer |
Since algolia does not enforce a schema on the records, it is possible that an highlighted value is only available on some of them. This means that react-instantsearch should not throw when highlighting an attribute that is missing from the hit. fix #1790
bobylito
force-pushed
the
fix/highlight-missing-attribute
branch
from
3909f1e to
c12f17c
Compare
vvo
pushed a commit
that referenced
this pull request
Jan 4, 2017
<a name="2.1.0"></a> # [2.1.0](v2.0.1...v2.1.0) (2017-01-04) ### Bug Fixes * **createInstantSearchManager:** drop outdated response (#1765) ([76c5312](76c5312)) * **highlight:** highlight should work even if the attribute is missing (#1791) ([5b79b15](5b79b15)), closes [#1790](#1790) * **InfiniteHits:** better classname to loadmore btn (#1789) ([ad2ded3](ad2ded3)) * **starRatings:** click on selected range doesn't unselect it (#1766) ([beacc72](beacc72)) * **website:** broken demo links (#1802) ([0abe2f5](0abe2f5)) * **widgets:** add 300px width for the default SearchBox (#1803) ([bf5d791](bf5d791)) ### Features * **InfiniteHits:** Add class to load more button (#1787) ([416febd](416febd)) * **RefinementList, connectRefinementList:** allow to search for facet values ([e086a81](e086a81))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What project are you opening a pull request for?
Summary
Since algolia does not enforce a schema on the records, it is possible
that an highlighted value is only available on some of them. This means
that react-instantsearch should not throw when highlighting an attribute
that is missing from the hit.
fix #1790