chore(script): automatic example module creation #5350

amcdnl · 2017-06-24T19:41:08Z

Enables the creation of the examples module and metadata associated with it by using jsdoc decorator tags. There are 3 required tags:

title: the title to be shown
id: the selector for the examples. e.g. 
component: the component class name

there are 3 other optional tags, these are:

addlComponents: Comma separated list of additional component class names required for the example. Required by snackbar component
additionalFiles: Comma separated list of additional files required for the example. Required by dialog component.
selectorName: Comma separated list of component class names required for the demo runner.

A simple example looks like:

/**
 * @title Stacked chips
 * @id chips-stacked
 * @component ChipsStackedExample
 */

more advanced scenarios such as snackbar and dialogs look like:

/**
 * @title Dialog elements
 * @id dialog-elements
 * @component DialogElementsExample
 * @addlComponents DialogElementsExampleDialog
 * @additionalFiles dialog-elements-example-dialog.html
 * @selectorName DialogElementsExample, DialogElementsExampleDialog
 */

Enables the creation of the examples module and metadata associated with it by using jsdoc decorator tags.

# Conflicts: # src/material-examples/example-module.ts

jelbourn

Initial batch of comment (fyi I tend to do multiple rounds of back-and-forth)

jelbourn · 2017-06-25T15:19:46Z

src/material-examples/dialog-elements/dialog-elements-example.ts

+ * @id dialog-elements
+ * @component DialogElementsExample
+ * @addlComponents DialogElementsExampleDialog
+ * @additionalFiles dialog-elements-example-dialog.html


Can we not detect additional files at the script level?

Ya, using something like a TypeScript parser we could detect these.

jelbourn · 2017-06-25T15:26:10Z

tools/gulp/tasks/docs.ts

@@ -177,3 +180,197 @@ function createTagNameAliaser(classPrefix: string) {
    return this;
  };
 }
+
+interface ExampleMetadata {


I'd put all the code related to generating the example module in its own file

Ok, I started that at first but moved into the same file at the end because of similarities. Do you have a filename in mind?

jelbourn · 2017-06-25T15:28:13Z

src/material-examples/autocomplete-overview/autocomplete-overview-example.ts

@@ -4,6 +4,11 @@ import {FormControl} from '@angular/forms';
 import 'rxjs/add/operator/startWith';
 import 'rxjs/add/operator/map';

+/**
+ * @title Basic autocomplete
+ * @id autocomplete-overview


Could we use the directory name (minus the -example) part) as the ID for each example? One less thing to manually keep consistent.

Ya, sounds like a good idea. Just a hold over from previous code.

jelbourn · 2017-06-25T15:38:57Z

src/material-examples/button-overview/button-overview-example.ts

+/**
+ * @title Basic buttons
+ * @id button-overview
+ * @component ButtonOverviewExample


Remind me why we can't extract the component name from the source?

I first tried require(file) and looking at the exported names but caused runtime issues. I spoke w/ @devversion and we have a plan to do this in typescript parser.

jelbourn · 2017-06-25T15:42:09Z

tools/gulp/tasks/docs.ts

+ * Builds the template for the examples module
+ * @param results
+ */
+const buildTemplate = (results: ExampleMetadata[]): string => {


For standalone functions like this, prefer function syntax:

function buildTemplate(...) { }

jelbourn · 2017-06-25T15:47:34Z

tools/gulp/tasks/docs.ts

+        .replace('.ts', '');
+
+      // get the decorator tags, not all required
+      const titleMatch = src.match(/@title.*/g);


Would this be easier to do this with the TypeScript compiler API rather than regexes?

Yeah most of the additionalFiles and additionalComponents could be detected using the TypeScript AST.

The only thing that is problematic would be the "demo" title for a given demo (because it wouldn't fit into the metadata)

Although the title could be part of the JSDoc of a component.

/** * @title Test Demo * @id my-id */ @Component({ ... } export class MyTestExample {}

Yeah, the title (and probably a description and maybe some other stuff later) will definitely have to be comments, but I think we can infer everything else.

Yeah. I think the TypeScript API also provides an easy way to retrieve the JSDoc of a given Node.

jelbourn · 2017-06-25T15:58:47Z

tools/gulp/tasks/docs.ts

+ */
+const buildTemplate = (results: ExampleMetadata[]): string => {
+  // create the import statements
+  const imports = (res: ExampleMetadata): string => {


I generally prefer more meaningful variable names without shortening (e.g, extractedMetadata instead of result)

jelbourn · 2017-06-25T15:59:47Z

tools/gulp/tasks/docs.ts

+  };
+
+  // create the examples metadat
+  const examples = (res: ExampleMetadata): string => {


Generally prefer not nesting functions like this rather than having them as standalone siblings. It makes it hard to separate the individual function behavior from the containing function.

jelbourn · 2017-06-25T16:00:50Z

tools/gulp/tasks/docs.ts

+  };
+
+  return `
+  import {NgModule} from '@angular/core';


It would be good to move this template to its own file.

@jelbourn - Where would you like this file to live?

Actually let's see how small it gets when moving the material modules into their own file; maybe then it will be short enough to leave as a string.

Ya, it ended up pretty small after that.

jelbourn · 2017-06-25T16:03:13Z

tools/gulp/tasks/docs.ts

+    MdListModule, MdMenuModule, MdProgressBarModule, MdProgressSpinnerModule,
+    MdRadioModule, MdSelectModule, MdSidenavModule, MdSliderModule,
+    MdSlideToggleModule, MdSnackBarModule, MdTabsModule, MdToolbarModule, MdTooltipModule
+  } from '@angular/material';


ExampleMaterialModule and LiveExample can go in their own TS files and just be imported rather than included in the template.

jelbourn · 2017-06-25T16:07:02Z

@devversion should also take a look

amcdnl · 2017-06-26T22:18:28Z

Per feedback from @devversion -

Resolve every export of a ts.SourceFile. There is a getExportsOfModule function
Walk through exports and check if it's a Component and if so -> analyze the decorator function call (resolve templateUrl and styleUrls) (edited)
Resolve example title and example id from JSDoc (using getDocumentationComment())

amcdnl · 2017-06-28T00:53:40Z

@devversion @jelbourn - I believe I have addressed the outstanding items. Can you please re-review?

jelbourn · 2017-06-28T00:56:09Z

tools/gulp/tasks/examples.ts

+ * Build the import template
+ * 
+ * @param {ExampleMetadata} metadata 
+ * @returns {string} template


Omit type from all JsDoc since it's captured by TypeScript (things like @param and @return can still have a description, though)

jelbourn · 2017-06-28T00:57:48Z

tools/gulp/tasks/examples.ts

+}
+
+/**
+ * Build the import template


Elaborate on what "the import template" is?

jelbourn · 2017-06-28T00:58:54Z

tools/gulp/tasks/examples.ts

+ * @returns {string} template
+ */
+function buildExamplesTemplate(metadata: ExampleMetadata): string {
+  const addlFiles = metadata.additionalFiles ? 


additionalFiles
(generally prefer to avoid abbreviations)

jelbourn · 2017-06-28T00:59:09Z

tools/gulp/tasks/examples.ts

+ */
+function buildExamplesTemplate(metadata: ExampleMetadata): string {
+  const addlFiles = metadata.additionalFiles ? 
+    JSON.stringify(metadata.additionalFiles) : 'undefined';


Why use a string 'undefined' instead of, say, null?
(add a comment?)

jelbourn · 2017-06-28T00:59:47Z

tools/gulp/tasks/examples.ts

+    JSON.stringify(metadata.additionalFiles) : 'undefined';
+
+  const selectorName = metadata.selectorName ? 
+    ("'" + metadata.selectorName.join(', ') + "'") : 'undefined';


Template string?

`'${metadata.selectorName.join(', ')}'`

jelbourn · 2017-06-28T01:03:08Z

tools/gulp/tasks/examples.ts

+ * @param {string} src 
+ * @returns {{ primary: any, seconds: any[] }} 
+ */
+function createMetas(filename: string, src: string): { primaryComponent: any, secondaryComponents: any[] } {


Can we tighten up the any use in this function? Or does the ts parser ironically not offer specific types?

I added a new interface for the parsed metadata.

I was having type issues with the visit function node, I'll revisit it and see if I can't tighten it up.

@devversion - I tinkered with tightening up the types in the visit function but had no luck.

I started off w/ const visit = (node: ts.Node) then when I hit ClassDeclaration I casted to that type, however, jsDoc is not a type on that node. I looked up the types and jsDoc is actually not a type on anything that extends ts.Node (odd?).

Also when I casted it, the decorator.expression.expression.text was no longer accessible. I tried the methods called getText() like we talked about but all returned TypeError: Cannot read property 'text' of undefined.

jelbourn · 2017-06-28T01:04:18Z

tools/gulp/tasks/examples.ts

+/**
+ * Creates the examples module and metadata
+ */
+task('build-examples-module', (cb) => {


Is the callback necessary if the task is synchronous? If so I'd call it done

Ya, you need to wait until all operations are completed before we mark the task completed.

jelbourn · 2017-06-28T01:06:50Z

tools/gulp/tasks/examples.ts

+}
+
+/**
+ * Build the list template


Elaborate on what "the list template" is?

jelbourn · 2017-06-28T01:07:11Z

tools/gulp/tasks/examples.ts

+ * @param {ExampleMetadata[]} extractedMetadata 
+ * @returns {string} resulting template
+ */
+function buildTemplate(extractedMetadata: ExampleMetadata[]): string {


Is this just generateExampleNgModule?

jelbourn · 2017-06-28T01:07:53Z

tools/gulp/tasks/examples.ts

+}
+
+/**
+ * Build the examples template


Elaborate on what "the examples template" is?

devversion · 2017-06-28T06:14:35Z

tools/gulp/tasks/examples.ts

+
+      const { primaryComponent, secondaryComponents } = createMetas(match, src);
+
+      if(primaryComponent) {


Nit: Space after the if here.

devversion · 2017-06-28T06:15:26Z

tools/gulp/tasks/examples.ts

+      if(primaryComponent) {
+        // convert the class name to dashcase id
+        let id = primaryComponent.component.replace('Example', '');
+        id = convertToDashCase(id);


You can make this is a const if you just combine the variable initialization.

convertToDashCase(primaryComponent.component.replace('Example', ''));

I try to avoid over complicated function invocation, but happy to change.

devversion · 2017-06-28T06:15:52Z

tools/gulp/tasks/examples.ts

+          selectorName: []
+        };
+
+        if(secondaryComponents.length) {


Space missing here and in the for loop below as well. (Do we have a lint rule for this?)

devversion · 2017-06-28T06:16:44Z

tools/gulp/tasks/examples.ts

+task('build-examples-module', (cb) => {
+  const results: ExampleMetadata[] = [];
+
+  glob('src/material-examples/**/*.ts', (err, matches) => {


To avoid the asynchronous here, just import glob.sync (as we do everywhere else)

import {sync as glob} from 'glob';

amcdnl · 2017-06-28T23:02:24Z

@jelbourn @devversion - Updated and ready for further review.

jelbourn

Just a last couple of style nits

jelbourn · 2017-06-29T15:40:57Z

tools/gulp/tasks/examples.ts

+            for(const tag of doc.tags) {
+              const tagValue = tag.comment;
+              const tagName = tag.tagName.text;
+              if(tagName === 'title') {


Nit: space between keyword and parenthesis (if, for)
(here and elsewhere)

jelbourn · 2017-06-29T15:41:22Z

tools/gulp/tasks/examples.ts

+ * Parse the AST of a file and get metadata about it
+ */
+function parseExampleMetadata(filename: string, src: string): 
+    { primaryComponent: ParsedMetadata, secondaryComponents: ParsedMetadata[] } {


Nit: no leading/trailing space in object literals
(here and elsewhere)

devversion · 2017-06-29T14:21:04Z

tools/gulp/tasks/examples.ts

+
+interface ExampleMetadata {
+  component: string;
+  filename: string;


fileName as for consistency with TypeScript API

devversion · 2017-06-29T14:23:00Z

tools/gulp/tasks/examples.ts

+    components.push(...metadata.additionalComponents);
+  }
+
+  return `import {${components.join(',')}} from '${metadata.filename}';


Maybe add a comment from where this template imports. This should explain what the root directory of this file is.

Also since the fileName (as in another comment) should be only the name, you should add the ./ prefix just here.

devversion · 2017-06-29T14:23:43Z

tools/gulp/tasks/examples.ts

+    const src = fs.readFileSync(file, 'utf-8');
+    const filename = file
+      .replace('src/material-examples/', './')
+      .replace('.ts', '');


Related to the other comments. This can be just path.basename(filePath); (the .ts extension should be fine to stay)

amcdnl · 2017-06-30T13:20:28Z

@devversion @jelbourn Ready for another review :)

jelbourn · 2017-06-30T18:30:27Z

tslint is now complaining about the generated file. Should add /* tslint:disable */ at the top of the generated file to avoid this.

devversion

Final round of comments from me.

devversion · 2017-06-30T22:52:35Z

tools/gulp/tasks/docs.ts

 import {buildConfig} from 'material2-build-tools';
+import * as fs from 'fs';


Why did you add the fs import here?

As far as I can tell, there is no readFileSync and writeFileSync in the docs.ts file

It was left over from my code in that file. I will remove.

devversion · 2017-06-30T22:54:34Z

tools/gulp/tasks/examples.ts

+
+/**
+ * Build ecmascript module import statements
+ */


This can be a a single-line comment.

/** Build ES2015 module imports for the specified example metadata */ function buildImportsTemplate(metadata: ExampleMetadata): string {

devversion · 2017-06-30T22:57:34Z

tools/gulp/tasks/examples.ts

+ * Build ecmascript module import statements
+ */
+function buildImportsTemplate(metadata: ExampleMetadata): string {
+  const components = [metadata.component];


const components =[metadata.component, ...metadata.additonalComponents];

You don't really need the check if there are additionalComponents. The additionalComponents property is always an array.

Alternative Solution:

const components = metadata.additonalComponents.concat(metadata.component)

Good call, left over from when it wasn't.

devversion · 2017-06-30T22:59:25Z

tools/gulp/tasks/examples.ts

+    components.push(...metadata.additionalComponents);
+  }
+
+  // imports the template from the /src/material-examples directory


// Create a relative path to the source file of the current example. // The relative path will be used inside of a TypeScript import statement.

devversion · 2017-06-30T22:59:58Z

tools/gulp/tasks/examples.ts

+  // imports the template from the /src/material-examples directory
+  const relativeSrcPath = path
+    .relative('./src/material-examples', metadata.sourcePath)
+    .replace('.ts', '');


We also need to replace the Windows backslashes here.

devversion · 2017-06-30T23:03:32Z

tools/gulp/tasks/examples.ts

+
+  if (metadata.additionalComponents) {
+    components.push(...metadata.additionalComponents);
+  }


This would be the same comment as for the imports. We should be able to drop the if check here.

devversion · 2017-06-30T23:07:50Z

tools/gulp/tasks/examples.ts

+    const { primaryComponent, secondaryComponents } = parseExampleMetadata(sourcePath, src);
+
+    if (primaryComponent) {
+      // convert the class name to dashcase id


// Generate a unique id for the component by converting the class name to dash-case.

devversion · 2017-06-30T23:08:18Z

tools/gulp/tasks/examples.ts

+      };
+
+      if (secondaryComponents.length) {
+        // for whatever reason the primary is listed here


This comment doesn't really help?

More of a reminder for myself, I'll remove.

devversion · 2017-06-30T23:08:41Z

tools/gulp/tasks/examples.ts

+    }
+  }
+
+  const template = generateExampleNgModule(results);


const generatedModuleFile = generateExampleNgModule(results);

devversion · 2017-06-30T23:09:05Z

tools/gulp/tasks/examples.ts

+/**
+ * Creates the examples module and metadata
+ */
+task('build-examples-module', (done) => {


Since we are now using gulp.sync we can just get rid of the done here.

amcdnl · 2017-07-01T18:15:28Z

@devversion @jelbourn - Ready for another review

devversion

LGTM. Three minor comments and then I think it's good to go.

devversion · 2017-07-02T10:50:40Z

tools/gulp/tasks/examples.ts

+
+  const matchedFiles = glob(path.join(examplesPath, '**/*.ts'));
+  for (const sourcePath of matchedFiles) {
+    const src = fs.readFileSync(sourcePath, 'utf-8');


The variable name src is pretty unclear. How about fileContent/sourceContent?

devversion · 2017-07-02T10:53:26Z

tools/gulp/tasks/examples.ts

+        component: node.name.text
+      };
+
+      let primary = false;


This variable seems to be unused?

devversion · 2017-07-02T11:01:00Z

tools/gulp/tasks/examples.ts

+ */
+function buildExamplesTemplate(metadata: ExampleMetadata): string {
+  // if no additional files or selectors were provided,
+  // return undefined since we don't care about if these were not found


Maybe change this comment to null now as well (since it's no longer undefined now). Maybe something like

// If there are no additional files or selectors specified, just set those variables // to an empty array. const additionalFiles = metadata.additionalFiles.length ? JSON.stringify(metadata.additionalFiles) : '[]';

Not sure if an empty array would make sense here. It would allow us to drop more null checks in the docs app. But null is also fine.

Adds a Stylelint rule that will prevent uses of nested mixins. This will help prevent issues like angular#5232 in the future.

* Randomizes the order of test execution inside of Jasmine / Karma.

…ngular#5547) * Most of the `whenStable()` promise calls can be replaced with the `flushMicrotasks` method, which just flushes them instead of waiting for them to really happen (when using `async`). * This reduces nesting of functions and also makes the tests in theory faster.

* With angular#5429 dgeni runs twice when running the `gulp docs` command. This is because the dgeni generate function has been added to the `dgeni/index.js` file.

* e2e(input): add textarea e2e test * test(input): remove fdescribe

The correct link is `/guide/cdk-table` instead of ~/guides/cdk-

…ar#5347) Uses the menu panel's overlay position to determine the animation origin, instead of the trigger. These changes make it easier to follow and avoid having to correct it explicitly based on the `overlapTrigger` flag, in addition to fixing some issues in nested menus.

Switches the `md-list` and `md-list-item` to `OnPush` change detection. Relates to angular#5035.

Fixes an issue that caused the wrong amount of options to be read out by NVDA. E.g. if the select has 3 options, NVDA reads out "<value> selected, 2 of 4". The issue seems to come from the fact that NVDA considers the trigger as one of the options, potentially because it's clickable.

…gular#5333) Prevents `textarea` instances from resizing beyond their `md-input-container`.

Fixes `md-chip` instances not being visible for users running high contrast mode.

…ular#5328) Fixes being able to set a disabled `md-select` to `touched` by clicking on it.

Adds an option to the dialog config that allows for the `aria-describedby` to be set on the dialog container.

…lar#5144) * fix(tooltip): remove native event listener on component destroy Component should clean up events it has registered to. Closes angular#4499 * Break at higher syntactic level * Undo accidental formatting

* Switches the snack bar component to `OnPush` change detection. * Removes the `detectChanges` workaround for the choppy animations, because it no longer works with `OnPush`. Properly fixes the initial issue by providing a `void` animation state. Relates to angular#5035.

…ngular#5555) * includes @angular/cdk in github material installation instructions * Mention the latest builds instructions Add the latest builds instructions in the installation section (Step 1). * Delete the installation section The Getting Started section has all the information necessary to proceed with installations: angular#5552 (comment)

* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker * In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.

* The root tsconfig file used to have proper autocompletion in editors like WebStorm is currently not working correctly. The path to the `@angular/cdk/testing` package is mapped to a non-existing folder.

* The PromiseCompleter is not used anywhere and in reality everbody can implement such a thing on his own. Also since there is the best practice to resolve/reject the promise while being inside of the anonymous function.

googlebot · 2017-07-08T16:34:49Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

amcdnl · 2017-07-08T16:37:54Z

I'm closing this PR and gonna redo it given all the merge issues.

angular-automatic-lock-bot · 2019-09-06T15:03:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

chore(script): automatic example module creation

3aea6d0

Enables the creation of the examples module and metadata associated with it by using jsdoc decorator tags.

amcdnl requested a review from jelbourn June 24, 2017 19:41

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2017

amcdnl added 2 commits June 24, 2017 14:54

Merge branch 'master' into doc-script

fc161b9

# Conflicts: # src/material-examples/example-module.ts

chore(*): add decorators to paginator examples

db5bb3c

jelbourn reviewed Jun 25, 2017

View reviewed changes

jelbourn requested a review from devversion June 25, 2017 16:06

jelbourn added the pr: needs review label Jun 26, 2017

chore(script): update to typescript parse

0402a94

jelbourn reviewed Jun 28, 2017

View reviewed changes

devversion reviewed Jun 28, 2017

View reviewed changes

chore(script): tweak for pr feedback

0c8c556

jelbourn reviewed Jun 29, 2017

View reviewed changes

devversion reviewed Jun 29, 2017

View reviewed changes

chore(linting): final cleanup

84fa0c8

chore(script): finish up some final tweaks

53744ce

devversion reviewed Jun 30, 2017

View reviewed changes

chore(script): final tweaks

4cd5bc8

devversion approved these changes Jul 2, 2017

View reviewed changes

devversion added pr: lgtm and removed pr: needs review labels Jul 2, 2017

amcdnl and others added 2 commits July 8, 2017 10:50

chore(script): fix PR feedback

4fc9e80

build: add stylelint rule to prevent nested mixins (angular#5354)

f1ffc60

Adds a Stylelint rule that will prevent uses of nested mixins. This will help prevent issues like angular#5232 in the future.

devversion and others added 22 commits July 8, 2017 11:29

build: randomize execution order of tests (angular#5425)

747e22a

* Randomizes the order of test execution inside of Jasmine / Karma.

chore: update readme for beta.8 (angular#5558)

1bdeeca

build: dgeni is building docs twice (angular#5536)

b495631

* With angular#5429 dgeni runs twice when running the `gulp docs` command. This is because the dgeni generate function has been added to the `dgeni/index.js` file.

test(input): add textarea e2e test (angular#5517)

f8ef901

* e2e(input): add textarea e2e test * test(input): remove fdescribe

docs(table): set correct CDK data-table link (angular#5565)

e5b16dc

The correct link is `/guide/cdk-table` instead of ~/guides/cdk-

chore(list): switch to OnPush change detection (angular#5520)

91e03f6

Switches the `md-list` and `md-list-item` to `OnPush` change detection. Relates to angular#5035.

fix(input): prevent textarea from resizing beyond input container (an…

e57b59a

…gular#5333) Prevents `textarea` instances from resizing beyond their `md-input-container`.

fix(chips): not visible in high contrast mode (angular#5338)

2610b72

Fixes `md-chip` instances not being visible for users running high contrast mode.

fix(select): disabled select being set to touched state on click (ang…

27599e0

…ular#5328) Fixes being able to set a disabled `md-select` to `touched` by clicking on it.

fix(dialog): add config option for aria-describedby (angular#5365)

40f95ca

Adds an option to the dialog config that allows for the `aria-describedby` to be set on the dialog container.

build: enable no-unused-variable lint rule (angular#5184)

83cdb93

* Now TSLint starts reporting unused variables again (Rule has been un-deprecated and now uses the type checker * In favor of linting the whole project the tsconfig file inside of `src/` needs to live in the project root.

build: incorrect path mapping in editor tsconfig (angular#5591)

48356de

* The root tsconfig file used to have proper autocompletion in editors like WebStorm is currently not working correctly. The path to the `@angular/cdk/testing` package is mapped to a non-existing folder.

refactor: remove unused promise completer (angular#5522)

8c2bb63

* The PromiseCompleter is not used anywhere and in reality everbody can implement such a thing on his own. Also since there is the best practice to resolve/reject the promise while being inside of the anonymous function.

chore(script): fix bug inserting all exported classes

2b8cdcc

chore(merge): manual merge of table examples and rebuild module

2fcf5b3

chore(script): rebuild on latest

c628047

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 8, 2017

amcdnl closed this Jul 8, 2017

amcdnl mentioned this pull request Jul 8, 2017

chore(script): autogenerate examples module and metadata #5608

Merged

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019


		const { primaryComponent, secondaryComponents } = createMetas(match, src);

		if(primaryComponent) {

		import {buildConfig} from 'material2-build-tools';
		import * as fs from 'fs';

chore(script): automatic example module creation #5350

chore(script): automatic example module creation #5350

Conversation

amcdnl commented Jun 24, 2017

jelbourn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcdnl Jun 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devversion Jun 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jelbourn commented Jun 25, 2017

amcdnl commented Jun 26, 2017

amcdnl commented Jun 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcdnl commented Jun 28, 2017

jelbourn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcdnl commented Jun 30, 2017 • edited Loading

jelbourn commented Jun 30, 2017

devversion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcdnl commented Jul 1, 2017

devversion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amcdnl Jun 26, 2017 •

edited

Loading

devversion Jun 25, 2017 •

edited

Loading

amcdnl commented Jun 30, 2017 •

edited

Loading