deprecate get_client and get_multi_client
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillLykov
approved these changes
Mar 11, 2024
CriesofCarrots
approved these changes
Mar 11, 2024
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
deprecate get_client and get_multi_client (cherry picked from commit 00c984f)
This was referenced Mar 11, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…a-xyz#177) (anza-xyz#182) * deprecate `get_client` and `get_multi_client` (anza-xyz#177) deprecate get_client and get_multi_client (cherry picked from commit 00c984f) * bump deprecated version numbers --------- Co-authored-by: Greg Cusack <greg.cusack@anza.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd PR on the way to remove ThinClient completely.
See
bench-tpsclient totpu-clientsolana-labs/solana#35335ThinClientand removeThinClientfrombench-tpssolana-labs/solana#35365This PR is made in response to: #117 (comment)
This PR must be merged before PR: #117
Problem
ThinClientis deprecated. Need to deprecateget_clientandget_multi_clientingossip/before removingThinClientfromdos/Summary of Changes
Deprecate
get_client(changed interface note) andget_multi_client(will be removed)