switch to solana-tpu-client from solana_client::tpu_client for bench-tps, dos/, LocalCluster, gossip/
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcusack
changed the title
solana-tpu-client from solana_client::tpu_client for bench-tps, dos/, LocalCluster, gossip/`solana-tpu-client from solana_client::tpu_client for bench-tps, dos/, LocalCluster, gossip/
gregcusack
force-pushed
the
tpu-client-from-entrypoint-switch-to-tpu-client
branch
3 times, most recently
from
79b12df to
0871dcc
Compare
gregcusack
force-pushed
the
tpu-client-from-entrypoint-switch-to-tpu-client
branch
from
0871dcc to
a5bd940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Followup PR to: #258. A setup the remove of
ThinClientfromLocalCluster. Removes dependency onsolana_client::tpu_clientand switches over tosolana-tpu-client.Requires PR: #258 to be merged first.
Problem
Building a
TpuClientwith a quic cache for tests can be cumbersome. Requires a decent amount of duplicate code.Summary of Changes
This is the 9th PR on the way to remove
ThinClientcompletely.See
bench-tpsclient totpu-clientsolana-labs/solana#35335ThinClientand removeThinClientfrombench-tpssolana-labs/solana#35365get_clientandget_multi_client#177get_clientandget_multi_client#184ThinClientfromdos/#117ThinClientfrombench-tps#132gossip_service::get_client()#227TpuClientforLocalClustertests #258