Deprecate ThinClient and remove ThinClient from bench-tps

[gregcusack]

2nd PR on the way to remove ThinClient completely.
See first PR: #35335

Problem

It is time to deprecate ThinClient as it is rarely used and only sends to one leader.

Summary of Changes

• Deprecate ThinClient
• Remove ThinClient from bench-tps

Note: I left in BenchTpsClient implementation for ThinClient since dos/ requires ThinClient as of now. Next PR will remove the dos/ ThinClient dependency.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (6ee3bb9) to head (ed7dd17).
Report is 30 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #35365    +/-   ##
========================================
  Coverage    81.7%    81.7%            
========================================
  Files         834      834            
  Lines      224299   224844   +545     
========================================
+ Hits       183361   183906   +545     
  Misses      40938    40938            

[CriesofCarrots]

Is this WIP or ready for review?

[gregcusack]

Is this WIP or ready for review?

oh yes sorry ready for review! forgot to remove the Work in Progress tag.

[CriesofCarrots]

Oh also: in future, when you're ready for review, it would be helpful if you could clean up the commits so they are concise and distinct. It's nice to review by commit, but easy to get bogged down when there are changes that are temporary, for debug only, etc.

[gregcusack]

Oh also: in future, when you're ready for review, it would be helpful if you could clean up the commits so they are concise and distinct. It's nice to review by commit, but easy to get bogged down when there are changes that are temporary, for debug only, etc.

ok will fix this! thank you for the tip

[CriesofCarrots]

r+ version nits

Looks great, thanks for the polish!
Much better commits, although if you find yourself listing multiple things in one commit (as in your 2nd one), those changes should usually be separated. No need to churn this one any further, though :)

[CriesofCarrots]

Suggested change

	#[deprecated(since = "2.0.0", note = "Use [RpcClient] or [TpuClient] instead.")]
	#[deprecated(since = "1.19.0", note = "Use [RpcClient] or [TpuClient] instead.")]

Since this is the repo's current version, let's go with this for now. I'll mention it to releng, but hopefully we can all remember to update these to v2 when that version bump lands.

[CriesofCarrots]

Suggested change

	This crate for `thin-client` is deprecated as of v2.0.0. It will receive no bugfixes or updates.
	This crate for `thin-client` is deprecated as of v1.19.0. It will receive no bugfixes or updates.

For now...