This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Release/1.25.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclusion of popularNordic ad sizes to default size list Removed redundant 104 size and added size 32 instead Fixed trailing comma
* PubWise Analytics * Updates based on Feedback
…rebid#1195) * Add type conversion into prebxdserver to handle inconsistent types. * Only check for params that exist. * adding test * fix string conversion and add unit tests * fix for code review * add debug output * remove accidental commit * newline
* Smart AdServer adapter Add Smart AdServer adapter with tests * fix not supported method Replace startsWith which is not supported in all browser version by lastIndexOf. * Issue with optional parameter Fix issue when no targeting is specified and remove "undefined" value passed in url * Add dynamic bidfloor option in the SmartAdServer prebid call.
* Upgraded to ESLint with stricter code style, for both sources and tests * Updated some dependencies and the yarn.lock file
* Add support for DigiTrust * Add rubicon tests covering digitrust failures * Remove whitespace in Rubicon adapter
…rebid#1133) * Remove batching mechanism and use AJAX instead of JSONP * Fix `undefined` value checks
* Rename secureCreatives file and lint * Updated package script for linting * Use 'gulp run-tests' in package script for testing
…rebid#1158) * Allowed setTargetingForGPTAsync() to target specific ad unit codes. Adds a paremeter to setTargetingForGPTAsync that allows it to set the targeting for specific ad unit codes (as divs). * Updated comments to pass linting.
* Fixes prebid#1114 possible xss issue * fix linting error
* load prebid per amp-ad iframe remove bidder setting, clean up PR adjust auction duration, clean up * example of single auction option
* Added some links, and reorganized the documentation a little bit. Removed some details which seemed superfluous to me. * Updated headers. * Spread the additional resources sections throughout the docs. Re-added some information about pull requests.
* Replaced que with queue. Made the line terminator characters in pbjs_example_gpt.html be unix-like, rather than windows-like. * Removed some redundant tests. * Separated que from queue, and added a deprecation warning. Wrote unit tests. * Limited the number of deprecation warnings to at most 2. * Style fixes. * Removed the deprecation warnings. * Renamed queue to cmd, per the github poll. * Fixed two more occurrences of outdated strings/comments.
* Prebid native * Support native mediaType on adUnits and validate native bidders * Recognize native mediaType on bid request and set on bid response * Validate bid response contains required native assets * Test native bid validation * Support v3 endpoint and response * Set up for writing native adapters array at build time * Fire native impression trackers * Use native targeting keys in enableSendAllBids * Update v3 native bid shapes * Build native-enabled adapters list from adapters.json * Fix linting errors * Move functions to utils * Use existing utils function * Fire requests for bidders that support native * Clarify mapping mechanism * Test native request * Add served ad to _winningBids * Camel case asset properties
* implement timeout on ajax requests * missing semi-colon
…every adUnit requested (prebid#1204) * No bid response has no ad unit, create bid response for every ad unit requested To fix prebid#1196 * Test to cover cases when response has no bids * Pass through the bid object to link request and response * Some fixes to support new linting * Populated wrong field * Generate status NO_BID response if server requested usersync
* Added ad unit size to bid request * Fixed lint errors * Added ad unit size to bid request * Prebid 0.23.1 Release * Add trafficSourceCode + test (prebid#1184) * pre release version bump * inclusion of popular Nordic ad sizes to default size list (prebid#1168) inclusion of popularNordic ad sizes to default size list Removed redundant 104 size and added size 32 instead Fixed trailing comma * Add PubWise Analytics (prebid#1151) * PubWise Analytics * Updates based on Feedback * add new rp_secure param to rubicon adapter (prebid#1190) * Add type conversion into PrebidServer to handle inconsistent types. (prebid#1195) * Add type conversion into prebxdserver to handle inconsistent types. * Only check for params that exist. * adding test * fix string conversion and add unit tests * fix for code review * add debug output * remove accidental commit * newline * Add dynamic bidfloor parameter to Smart Adserver Adapter (prebid#1194) * Smart AdServer adapter Add Smart AdServer adapter with tests * fix not supported method Replace startsWith which is not supported in all browser version by lastIndexOf. * Issue with optional parameter Fix issue when no targeting is specified and remove "undefined" value passed in url * Add dynamic bidfloor option in the SmartAdServer prebid call. * Bug fix: bids served by secure creatives does not get pushed into _winningBids (prebid#1192) * Upgrade linters to ESLint with stricter code style (prebid#1111) * Upgraded to ESLint with stricter code style, for both sources and tests * Updated some dependencies and the yarn.lock file * Add Support for DigiTrust in Rubicon Adapter (prebid#1201) * Add support for DigiTrust * Add rubicon tests covering digitrust failures * Remove whitespace in Rubicon adapter * HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (prebid#1133) * Remove batching mechanism and use AJAX instead of JSONP * Fix `undefined` value checks * Rename secureCreatives file and lint (prebid#1203) * Rename secureCreatives file and lint * Updated package script for linting * Use 'gulp run-tests' in package script for testing * updated tag (prebid#1212) * Common user-sync (prebid#1144) * Changed “bidRequest” to “bid” for clarity
* fix bug and unit tests * Fix space * PR review fix * Address review comments. Fix 1 more bug :) * Add back alias * Make sure we reset targeting properly based on input type. * update per review * defensive coding
…e/Prebid-official-0.26.0 # Conflicts: # adapters.json # analytics.json # gulpfile.js # karma.conf.js # loaders/adapterLoader.js # modules/aolBidAdapter.js # src/bidmanager.js # test/spec/loaders/adapterLoader_spec.js
* Fired the bid adjustment event at (what I think is) the appropriate time. * More thorough tests. * Better test description. * Removed a stray console.log
* Lint modules directory * Run --fix * Add indentation exception for adapter * Push lint error to test CI * Fix forced error
* fix 1410 - issue with ie and xhr.timeout * update comment
# Conflicts: # src/bidmanager.js
…LMP-187-new-prebid-structure to release/1.25.0 * commit '96f4903bb86bbfe1401ae1b6d9211c00a1c41b45': Added banner for minified source file. Improve matching to avoid breaking js syntax. Changed changelog entry. Fixed invalid module link. Added changelog entry. Added ids in aolPartnersIds. Added tests for delimiterLoader. Improved adapter source code wrappig. Changed aol analytics adapter to new structure. Get rid of preserve keyword. Added preserved keyword for adapters wrapping. Added wrapper for bid and analytic adapters.
….25.0 to aolgithub-master * commit '2a31c81b71595988ed2bf3470fb94d4fb75098bc': (71 commits) Sync with contrib/aol-adapter-aliases branch. Added junit reporter, improved browserstack tests running. Change browsers config to allow run tests on CI. Temporary comment unit test to provide compatibility with pre-bidder timeout feature. Added banner for minified source file. Improve matching to avoid breaking js syntax. Changed changelog entry. Fixed invalid module link. Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Added changelog entry. Added ids in aolPartnersIds. Added tests for delimiterLoader. Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Improved adapter source code wrappig. Changed aol analytics adapter to new structure. Get rid of preserve keyword. Added preserved keyword for adapters wrapping. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information