refactor: migrate timeseries_limit_metric to legacy_order_by

[zhaoyongjie]

🏆 Enhancements
backend changes at: apache/superset#16849

currently, Superset use timeseries_limit_metric control for main query orderby. While this is actually prepared for the inner query when viz is timeseries-like.

To fix the original incorrect use, so this PR introduce a legacy_order_by control.

This PR only migrate pivot table v2.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/B533s6CjW8hxaHryshpXw2CYzndd
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-addlegacyordery-superset.vercel.app

[codecov]

Codecov Report

Merging #1364 (f655aac) into master (90463d2) will increase coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage   30.31%   30.34%   +0.03%     
==========================================
  Files         496      497       +1     
  Lines        9974     9977       +3     
  Branches     1678     1679       +1     
==========================================
+ Hits         3024     3028       +4     
+ Misses       6706     6704       -2     
- Partials      244      245       +1     

Impacted Files	Coverage Δ
packages/superset-ui-chart-controls/src/index.ts	100.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx	36.00% <0.00%> (-0.37%)	⬇️
...lugin-chart-pivot-table/src/plugin/controlPanel.ts	12.50% <ø> (ø)
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts	81.81% <66.66%> (+10.38%)	⬆️
...hart-controls/src/shared-controls/legacySortBy.tsx	100.00% <100.00%> (ø)
...ges/superset-ui-core/src/query/normalizeOrderBy.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90463d2...f655aac. Read the comment docs.

[zhaoyongjie]

will be refactored in separate PR .

[villebro]

LGTM - only comment is should we perform a db migration to avoid breaking existing charts that are leveraging the old sorting control?

[rusackas]

@zhaoyongjie is the migration that @villebro mentioned being tackled? I hope to avoid any reports of broken charts from users.

Nevermind! Found it! Thank you!