Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: db migrate timeseries_limit_metric to legacy_order_by #16849

Merged

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Frontend changes at: apache-superset/superset-ui#1364

currently, Superset use timeseries_limit_metric control for main query orderby. While this is actually prepared for the inner query when viz is timeseries-like.

To fix the original incorrect use, so this PR introduce a legacy_order_by control.

This PR only migrate pivot table v2.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #16849 (a47582d) into master (ef95458) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head a47582d differs from pull request most recent head c035afb. Consider uploading reports for the commit c035afb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16849      +/-   ##
==========================================
- Coverage   77.01%   76.79%   -0.22%     
==========================================
  Files        1021     1021              
  Lines       54716    54715       -1     
  Branches     7461     7461              
==========================================
- Hits        42138    42017     -121     
- Misses      12334    12454     +120     
  Partials      244      244              
Flag Coverage Δ
hive ?
mysql 81.84% <ø> (ø)
postgres 81.91% <ø> (ø)
presto ?
python 81.99% <ø> (-0.43%) ⬇️
sqlite 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/FiltersBadge/selectors.ts 79.45% <100.00%> (-0.14%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.59% <0.00%> (-1.66%) ⬇️
superset/models/core.py 89.08% <0.00%> (-0.75%) ⬇️
superset/db_engine_specs/base.py 88.17% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.84% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef95458...c035afb. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@villebro villebro mentioned this pull request Sep 27, 2021
9 tasks
@zhaoyongjie zhaoyongjie merged commit bbe7aa3 into apache:master Sep 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants