Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84: Migrating GET one queued asset events for DAG to fastAPI #44128

Merged

Conversation

amoghrajesh
Copy link
Contributor

related: #42370

Same setup as #44124 and dependent on #44124

Responses:

  1. Legacy
    image

  2. FastAPI
    image

With time filtering

  1. Legacy
    image

  2. FastAPI
    image

Swagger spec:
image

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@amoghrajesh
Copy link
Contributor Author

Only last commit is relevant

@amoghrajesh amoghrajesh self-assigned this Nov 18, 2024
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nitpick. but overall looks good

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
amoghrajesh and others added 2 commits November 18, 2024 17:41
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one small update required, feel free to merge after

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@amoghrajesh amoghrajesh force-pushed the AIP84-get-one-queued-event-for-dag-again branch from 389d09e to 449420c Compare November 18, 2024 18:48
@amoghrajesh amoghrajesh merged commit af958bb into apache:main Nov 19, 2024
62 checks passed
@amoghrajesh amoghrajesh deleted the AIP84-get-one-queued-event-for-dag-again branch November 19, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants