Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84: Migrating GET one queued asset events for DAG to fastAPI #44013

Closed

Conversation

amoghrajesh
Copy link
Contributor

related: #42370

Same setup as #43934 and dependent on #43934

Responses:

  1. Legacy
    image

  2. FastAPI
    image

With time filtering

  1. Legacy
    image

  2. FastAPI
    image

Swagger spec:
image

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 14, 2024
@amoghrajesh amoghrajesh added the legacy api Whether legacy API changes should be allowed in PR label Nov 14, 2024
@amoghrajesh
Copy link
Contributor Author

Only last 2 commits are relevant

@amoghrajesh amoghrajesh self-assigned this Nov 14, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments from #43934 code review also apply here.

I'll do a final review later once updated and other base PRs are merged.

@amoghrajesh
Copy link
Contributor Author

Closing in favour of #44128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants