Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qos command remote check #11506

Merged
merged 4 commits into from
Feb 26, 2023
Merged

Fix qos command remote check #11506

merged 4 commits into from
Feb 26, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Feb 8, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.1% 95.1% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11506 (60460d3) into 3.2 (a1dea63) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11506      +/-   ##
============================================
- Coverage     69.00%   69.00%   -0.01%     
  Complexity        2        2              
============================================
  Files          1496     1496              
  Lines         62503    62520      +17     
  Branches       9204     9207       +3     
============================================
+ Hits          43131    43140       +9     
- Misses        15143    15158      +15     
+ Partials       4229     4222       -7     
Impacted Files Coverage Δ
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 54.54% <0.00%> (-18.19%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 64.00% <0.00%> (-4.00%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 71.52% <0.00%> (-2.72%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.09% <0.00%> (-2.39%) ⬇️
.../org/apache/dubbo/qos/common/QosConfiguration.java 88.63% <0.00%> (-1.69%) ⬇️
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 80.28% <0.00%> (-1.41%) ⬇️
...o/qos/server/handler/ForeignHostPermitHandler.java 73.91% <0.00%> (-1.09%) ⬇️
...adata/store/zookeeper/ZookeeperMetadataReport.java 72.34% <0.00%> (-1.07%) ⬇️
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 71.42% <0.00%> (-0.96%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 76.22% <0.00%> (-0.82%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 57c58de into apache:3.2 Feb 26, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
* Fix qos command remote check

* update

* Fix NPE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants