Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration bugfix & optimization #11629

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Migration bugfix & optimization #11629

merged 3 commits into from
Feb 25, 2023

Conversation

mytang0
Copy link
Member

@mytang0 mytang0 commented Feb 22, 2023

What is the purpose of the change

  1. Fix volatile problem
  2. Thread pool leak fix
  3. Code optimization

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@mytang0 mytang0 changed the title Migration bugfix & opt Migration bugfix & optimization Feb 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11629 (04fe387) into 3.2 (10e7162) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11629      +/-   ##
============================================
- Coverage     69.73%   69.59%   -0.14%     
+ Complexity      339        2     -337     
============================================
  Files          1573     1382     -191     
  Lines         84263    59982   -24281     
  Branches      15298     8915    -6383     
============================================
- Hits          58758    41747   -17011     
+ Misses        20584    14092    -6492     
+ Partials       4921     4143     -778     
Impacted Files Coverage Δ
...t/migration/DefaultMigrationAddressComparator.java
...bo/registry/client/migration/MigrationInvoker.java
...egistry/client/migration/MigrationRuleHandler.java
...gistry/client/migration/MigrationRuleListener.java
...moting/transport/netty4/Netty4BatchWriteQueue.java
...ache/dubbo/cache/support/expiring/ExpiringMap.java
...gistrycenter/initializer/ZookeeperInitializer.java
...enter/support/nacos/NacosConfigServiceWrapper.java
...ache/dubbo/rpc/protocol/dubbo/DubboCountCodec.java
...adata/store/zookeeper/ZookeeperMetadataReport.java
... and 2945 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit d57ad31 into apache:3.2 Feb 25, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 27, 2023
* origin/3.2:
  sync reflect config (apache#11668)
  Fix qos command remote check (apache#11506)
  Fix license check
  Add 'label match' support for override and tag rules (apache#11094)
  Dubbo maven plugin with native (apache#11540)
  fix: fix observation spi config (apache#11660)
  Update .licenserc.yaml
  fix tri wrapper pack npe (apache#11656)
  remove duplicate flowcontroller listener (apache#11642)
  Metrics RT count optimization (apache#11628)
  Observability task: registration center (apache#11493)
  Migration bugfix & optimization (apache#11629)
  Fix service name mapping check failed (apache#11643)
  fix: executor (apache#11652)
  Fix license check
  fixed broken link readme.md (apache#11641)
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
* Code optimize

* Thread pool leak fix

* Fix volatile problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants