-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics RT count optimization #11628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please take a look @songxiaosheng |
ok please wait |
songxiaosheng
requested changes
Feb 22, 2023
...fault/src/main/java/org/apache/dubbo/metrics/collector/sample/SimpleMetricsCountSampler.java
Outdated
Show resolved
Hide resolved
* origin/3.2: Observability task: metadata center (apache#11593) Enhance the way to get dubbo version (apache#11574) Bump protobuf-java from 3.21.12 to 3.22.0 (apache#11615) Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11613) Bump micrometer-bom from 1.10.3 to 1.10.4 (apache#11611) Bump libthrift from 0.17.0 to 0.18.0 (apache#11614) Bump maven-failsafe-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11612) Bump reactor-core from 3.5.2 to 3.5.3 (apache#11610) Bump byte-buddy from 1.13.0 to 1.14.0 (apache#11609) Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (apache#11608) Bump micrometer-tracing-bom from 1.0.1 to 1.0.2 (apache#11607) 3.2 consumer proxy invocation handler (apache#11108)
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Feb 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mytang0
added a commit
to mytang0/dubbo
that referenced
this pull request
Feb 27, 2023
* origin/3.2: sync reflect config (apache#11668) Fix qos command remote check (apache#11506) Fix license check Add 'label match' support for override and tag rules (apache#11094) Dubbo maven plugin with native (apache#11540) fix: fix observation spi config (apache#11660) Update .licenserc.yaml fix tri wrapper pack npe (apache#11656) remove duplicate flowcontroller listener (apache#11642) Metrics RT count optimization (apache#11628) Observability task: registration center (apache#11493) Migration bugfix & optimization (apache#11629) Fix service name mapping check failed (apache#11643) fix: executor (apache#11652) Fix license check fixed broken link readme.md (apache#11641)
lcb11
pushed a commit
to lcb11/dubbo
that referenced
this pull request
Mar 31, 2023
* Metrics RT count optimization * Fix camel case naming problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Optimize the logic of addRT and collectRT:
old
new
Brief changelog
Verifying this change
Checklist