Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pylint): Reenable super-with-arguments check #16138

Merged
merged 1 commit into from
Aug 16, 2021
Merged

chore(pylint): Reenable super-with-arguments check #16138

merged 1 commit into from
Aug 16, 2021

Conversation

john-bodley
Copy link
Member

SUMMARY

Re-enabling the Pylint super-with-arguments check.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--pylint-reenable-super-with-arguments branch from 12f1cb2 to f7574e0 Compare August 9, 2021 05:10
@pull-request-size pull-request-size bot added size/S and removed size/L labels Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #16138 (6718cc9) into master (4cb79e5) will decrease coverage by 0.19%.
The diff coverage is 57.01%.

❗ Current head 6718cc9 differs from pull request most recent head f7574e0. Consider uploading reports for the commit f7574e0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16138      +/-   ##
==========================================
- Coverage   76.90%   76.71%   -0.20%     
==========================================
  Files         995      995              
  Lines       52842    52884      +42     
  Branches     6709     6721      +12     
==========================================
- Hits        40640    40569      -71     
- Misses      11976    12090     +114     
+ Partials      226      225       -1
Flag Coverage Δ
hive ?
mysql 81.58% <60.65%> (-0.04%) ⬇️
postgres 81.60% <60.65%> (-0.04%) ⬇️
presto 81.44% <60.65%> (-0.04%) ⬇️
python 81.87% <60.65%> (-0.30%) ⬇️
sqlite 81.24% <60.65%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.69% <0.00%> (-0.02%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 90.47% <ø> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx 55.55% <0.00%> (-0.79%) ⬇️
...FormattingControl/ConditionalFormattingControl.tsx 21.66% <0.00%> (-0.75%) ⬇️
...onalFormattingControl/FormattingPopoverContent.tsx 29.26% <0.00%> (-4.07%) ⬇️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 94.83% <ø> (ø)
superset-frontend/src/reports/actions/reports.js 10.86% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.53% <0.00%> (-0.36%) ⬇️
...set-frontend/src/views/CRUD/data/database/types.ts 100.00% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb79e5...f7574e0. Read the comment docs.

@john-bodley john-bodley changed the title chore(pylint): Re-enable super-with-arguments check chore(pylint): Reenable super-with-arguments check Aug 15, 2021
@john-bodley john-bodley merged commit 8e07dd2 into apache:master Aug 16, 2021
@john-bodley john-bodley deleted the john-bodley--pylint-reenable-super-with-arguments branch August 16, 2021 16:00
amitmiran137 pushed a commit that referenced this pull request Aug 16, 2021
Merge branch 'master' into feat/extra_strategies
6c9f0fb 
* master:
  chore(pylint): Reenable ungrouped-imports check (#16256)
  chore(pylint): Re-enable super-with-arguments check (#16138)
  fix: disable text reports for now (#16257)
  fix: pivot col names in post_process (#16262)
  chore: Improves the flow to create a new chart (#16252)
  Move pagination outside of table (#16232)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@john-bodley
chore(pylint): Re-enable super-with-arguments check (apache#16138)
7e2fe74 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@john-bodley
chore(pylint): Re-enable super-with-arguments check (apache#16138)
358efc7 
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @villebro @mistercrunch